From: Lee Jones <lee.jones@linaro.org>
To: Michael Welling <mwelling@emacinc.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
rogerq@ti.com, gregkh@linuxfoundation.org,
stern@rowland.harvard.edu, balbi@ti.com, stable@vger.kernel.org
Subject: [PATCH] mfd: omap-usb-host: Fix improper mask use
Date: Tue, 29 Jul 2014 09:33:25 +0100 [thread overview]
Message-ID: <20140729083325.GA9030@lee--X1> (raw)
In-Reply-To: <1406588464-19104-1-git-send-email-mwelling@emacinc.com>
single-ulpi-bypass is a flag used for older OMAP3 silicon.
The flag when set, can excite code that improperly uses the
OMAP_UHH_HOSTCONFIG_UPLI_BYPASS define to clear the corresponding bit.
Instead it clears all of the other bits disabling all of the ports in
the process.
Signed-off-by: Michael Welling <mwelling@emacinc.com>
---
--> Applied, thanks. <--
drivers/mfd/omap-usb-host.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index b48d80c..33a9234 100644
--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -445,7 +445,7 @@ static unsigned omap_usbhs_rev1_hostconfig(struct usbhs_hcd_omap *omap,
for (i = 0; i < omap->nports; i++) {
if (is_ehci_phy_mode(pdata->port_mode[i])) {
- reg &= OMAP_UHH_HOSTCONFIG_ULPI_BYPASS;
+ reg &= ~OMAP_UHH_HOSTCONFIG_ULPI_BYPASS;
break;
}
}
next prev parent reply other threads:[~2014-07-29 8:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 23:01 [PATCH] drivers:mfd:omap-usb-host.c: Fix improper mask use Michael Welling
2014-07-29 7:02 ` Roger Quadros
2014-07-29 8:33 ` Lee Jones [this message]
2014-07-29 14:57 ` [PATCH] mfd: omap-usb-host: " Greg KH
2014-07-29 15:10 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140729083325.GA9030@lee--X1 \
--to=lee.jones@linaro.org \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mwelling@emacinc.com \
--cc=rogerq@ti.com \
--cc=stable@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox