From: Dan Carpenter <dan.carpenter@oracle.com>
To: Tobias Klauser <tklauser@distanz.ch>
Cc: Anil Belur <askb23@gmail.com>,
devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
silvio.fricke@gmail.com, linux-kernel@vger.kernel.org,
bjorn@mork.no
Subject: Re: [PATCH 1/1] drivers: staging: vt6655: ioctl.c - missing __user annotation
Date: Tue, 29 Jul 2014 12:17:51 +0300 [thread overview]
Message-ID: <20140729091751.GB4856@mwanda> (raw)
In-Reply-To: <20140729080538.GA16199@distanz.ch>
On Tue, Jul 29, 2014 at 10:05:38AM +0200, Tobias Klauser wrote:
> On 2014-07-28 at 09:58:12 +0200, Anil Belur <askb23@gmail.com> wrote:
> > From: Anil Belur <askb23@gmail.com>
> >
> > - private_ioctl() the internally calls copy_{to,from}_user() and does
> > not use '__user' while refrencing user space pointers.
> > - this patch passes __user annotation as a cast, when the pointer is
> > being refernced.
>
> Wouldn't it be better to annotate the data member in struct tagSCmdRequest
> with __user instead of introducing all these casts?
Don't ask rhetorical questions on email lists. Just be blunt.
These casts are not the correct fix.
regards,
dan carpenter
next prev parent reply other threads:[~2014-07-29 9:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 7:58 [PATCH 1/1] drivers: staging: vt6655: ioctl.c - missing __user annotation Anil Belur
2014-07-29 8:05 ` Tobias Klauser
2014-07-29 9:17 ` Dan Carpenter [this message]
2014-07-30 2:34 ` Anil Shashikumar Belur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140729091751.GB4856@mwanda \
--to=dan.carpenter@oracle.com \
--cc=askb23@gmail.com \
--cc=bjorn@mork.no \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=silvio.fricke@gmail.com \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox