From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andres Freund <andres@anarazel.de>
Cc: Namhyung Kim <namhyung@gmail.com>, Jiri Olsa <jolsa@redhat.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Andi Kleen <andi@firstfloor.org>, Arun Sharma <asharma@fb.com>,
Rodrigo Campos <rodrigo@sdfg.com.ar>,
Don Zickus <dzickus@redhat.com>
Subject: Re: [PATCH 22/27] perf tools: Enable --children option by default
Date: Tue, 29 Jul 2014 10:06:50 -0300 [thread overview]
Message-ID: <20140729130650.GP7831@kernel.org> (raw)
In-Reply-To: <20140729114548.GA27368@alap3.anarazel.de>
Em Tue, Jul 29, 2014 at 01:45:48PM +0200, Andres Freund escreveu:
> On 2014-07-29 15:52:46 +0900, Namhyung Kim wrote:
> > Yes, I knew it'd annoy some existing users like you :)
And me :-)
> > But I hoped it'd be useful for new and (at least, some of) old users
> > to see children/ cumulative overheads by default. If it lies under
> > an option, it wouldn't have a chance to be used by normal users who
> > simply run perf record and report most of time.
> By that argument every new feature would need to be enabled by
> default. Which normally isn't what happens.
> > If you think it's entirely useless for you cases, you can set it to off
> > using ~/.perfconfig file:
> > [report]
> > children = false
> Already done that ;).
:-)
> The problem is still that I can't use --no-children on older systems, so
> I can't write benchmarking scripts anymore that don't take depend on the
> perf version...
> I guess it's too late to argue effectively though :)
yeah, changing the output people are used to in such a big way is not
nice.
Perhaps next time we should instead present a dialog box at 'perf
report' start allowing people to opt-in, having a nice explanation about
why one would want to switch the default while alowing people to say:
[x] No, Thanks
- Arnaldo
next prev parent reply other threads:[~2014-07-29 13:06 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 3:58 [PATCHSET 00/27] perf tools: Add support to accumulate hist periods (v11) Namhyung Kim
2014-05-29 3:58 ` [PATCH 01/27] perf tools: Introduce hists__inc_nr_samples() Namhyung Kim
2014-06-03 18:31 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29 3:58 ` [PATCH 02/27] perf tools: Introduce struct hist_entry_iter Namhyung Kim
2014-06-03 18:31 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29 3:58 ` [PATCH 03/27] perf hists: Add support for accumulated stat of hist entry Namhyung Kim
2014-06-03 18:31 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29 3:58 ` [PATCH 04/27] perf hists: Check if accumulated when adding a " Namhyung Kim
2014-06-03 18:31 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29 3:58 ` [PATCH 05/27] perf hists: Accumulate hist entry stat based on the callchain Namhyung Kim
2014-06-03 18:32 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29 3:58 ` [PATCH 06/27] perf tools: Update cpumode for each cumulative entry Namhyung Kim
2014-06-03 18:32 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29 3:58 ` [PATCH 07/27] perf report: Cache cumulative callchains Namhyung Kim
2014-06-03 18:32 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29 3:58 ` [PATCH 08/27] perf callchain: Add callchain_cursor_snapshot() Namhyung Kim
2014-06-03 18:32 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29 3:58 ` [PATCH 09/27] perf tools: Save callchain info for each cumulative entry Namhyung Kim
2014-06-03 18:33 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29 3:58 ` [PATCH 10/27] perf ui/hist: Add support to accumulated hist stat Namhyung Kim
2014-06-03 18:33 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29 3:58 ` [PATCH 11/27] perf ui/browser: " Namhyung Kim
2014-06-03 18:33 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29 3:58 ` [PATCH 12/27] perf ui/gtk: " Namhyung Kim
2014-06-03 18:33 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29 3:58 ` [PATCH 13/27] perf tools: Apply percent-limit to cumulative percentage Namhyung Kim
2014-06-03 18:33 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29 3:58 ` [PATCH 14/27] perf tools: Add more hpp helper functions Namhyung Kim
2014-06-03 18:34 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29 3:58 ` [PATCH 15/27] perf report: Add --children option Namhyung Kim
2014-06-03 18:34 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29 3:58 ` [PATCH 16/27] perf report: Add report.children config option Namhyung Kim
2014-06-03 18:34 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29 3:58 ` [PATCH 17/27] perf tools: Do not auto-remove Children column if --fields given Namhyung Kim
2014-06-03 18:34 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29 3:58 ` [PATCH 18/27] perf tools: Add callback function to hist_entry_iter Namhyung Kim
2014-05-29 13:16 ` Jiri Olsa
2014-05-30 4:50 ` Namhyung Kim
2014-06-03 18:34 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29 3:58 ` [PATCH 19/27] perf top: Convert " Namhyung Kim
2014-06-03 18:35 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29 3:58 ` [PATCH 20/27] perf top: Add --children option Namhyung Kim
2014-06-03 18:35 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29 3:58 ` [PATCH 21/27] perf top: Add top.children config option Namhyung Kim
2014-06-03 18:35 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29 3:58 ` [PATCH 22/27] perf tools: Enable --children option by default Namhyung Kim
2014-06-03 18:35 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-07-28 19:23 ` [PATCH 22/27] " Andres Freund
2014-07-29 6:52 ` Namhyung Kim
2014-07-29 11:45 ` Andres Freund
2014-07-29 13:06 ` Arnaldo Carvalho de Melo [this message]
2014-07-29 23:29 ` Namhyung Kim
2014-05-29 3:58 ` [PATCH 23/27] perf ui/stdio: Fix invalid percentage value of cumulated hist entries Namhyung Kim
2014-06-03 18:35 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29 3:58 ` [PATCH 24/27] perf ui/gtk: Fix callchain display Namhyung Kim
2014-06-03 18:36 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29 3:58 ` [PATCH 25/27] perf tools: Reset output/sort order to default Namhyung Kim
2014-06-03 18:36 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29 3:58 ` [PATCH 26/27] perf tests: Define and use symbolic names for fake symbols Namhyung Kim
2014-06-03 18:36 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29 3:58 ` [PATCH 27/27] perf tests: Add a test case for cumulating callchains Namhyung Kim
2014-06-03 18:36 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29 13:59 ` [PATCHSET 00/27] perf tools: Add support to accumulate hist periods (v11) Jiri Olsa
2014-05-30 4:58 ` Namhyung Kim
-- strict thread matches above, loose matches on Subject: below --
2014-06-01 13:31 [GIT PULL 00/27] perf/core improvements and fixes Jiri Olsa
2014-06-01 13:31 ` [PATCH 22/27] perf tools: Enable --children option by default Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140729130650.GP7831@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=andres@anarazel.de \
--cc=asharma@fb.com \
--cc=dsahern@gmail.com \
--cc=dzickus@redhat.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@gmail.com \
--cc=paulus@samba.org \
--cc=rodrigo@sdfg.com.ar \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox