From: Johan Hovold <johan@kernel.org>
To: Wang YanQing <udknight@gmail.com>
Cc: gregkh@linuxfoundation.org, linus.walleij@linaro.org,
jhovold@gmail.com, andi@lisas.de, dforsi@gmail.com,
gnomes@lxorguk.ukuu.org.uk, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6] usb:serial:pl2303: add GPIOs interface on PL2303
Date: Tue, 29 Jul 2014 22:31:45 +0200 [thread overview]
Message-ID: <20140729203145.GM12963@localhost> (raw)
In-Reply-To: <20140729165709.GA3380@udknight>
On Wed, Jul 30, 2014 at 12:57:09AM +0800, Wang YanQing wrote:
> PL2303HX has two GPIOs, this patch add interface for it.
>
> Signed-off-by: Wang YanQing <udknight@gmail.com>
> ---
> Changes v5-v6:
> 1: fix typo error in Kconfig reported by Andreas Mohr
> 2: add const qulification to gpio_dir_mask and gpio_value_mask suggested by Andreas Mohr
>
> Hi, Linus Walleij, I see you give your review-by to v4, but v4
> has a obvious bug (template_chip overwrite label's value), so
> could you review this version? Thanks!
>
> Greg KH, although I really hope this is the last version,
> but what is your suggestion?
>
> Thanks again for all guys' review and correction.
I haven't had a chance to look at this patch yet due to travels.
Hopefully I should be able to provide some feedback within the next few
days.
Johan
next prev parent reply other threads:[~2014-07-29 20:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 16:57 [PATCH v6] usb:serial:pl2303: add GPIOs interface on PL2303 Wang YanQing
2014-07-29 20:31 ` Johan Hovold [this message]
2014-08-04 14:00 ` Johan Hovold
2014-08-04 17:15 ` Resend " Wang YanQing
2014-08-05 13:54 ` Johan Hovold
2014-08-07 19:10 ` Wang YanQing
2014-08-08 7:54 ` Johan Hovold
2014-08-08 18:46 ` Wang YanQing
2014-08-12 14:02 ` Johan Hovold
2014-08-27 23:38 ` Wang YanQing
2014-08-29 10:38 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140729203145.GM12963@localhost \
--to=johan@kernel.org \
--cc=andi@lisas.de \
--cc=dforsi@gmail.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jhovold@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=udknight@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).