From: Tejun Heo <tj@kernel.org>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 2/2 V2] workqueue: use dedicated creater kthread for all pools
Date: Tue, 29 Jul 2014 23:23:34 -0400 [thread overview]
Message-ID: <20140730032334.GA15787@htj.dyndns.org> (raw)
In-Reply-To: <53D83D33.80101@cn.fujitsu.com>
Hello, Lai.
On Wed, Jul 30, 2014 at 08:32:51AM +0800, Lai Jiangshan wrote:
> > Why? Just sleep and retry? What's the point of requeueing?
>
> Accepted your comments except this one which may need to discuss
> for an additional round. Requeueing passes the retry to the
> kthread_worker and gives a change to the other pools which are also
> creating worker.
But why is that a good idea? The fact that creation of a worker for a
specific pool is completely coincidental. The failed pool itself
isn't inherently blameable. It was just unlucky and moving onto a
different pool doesn't improve the chance of success in any way. The
only thing requeueing achieves is punishing the unlucky one by putting
it at the back of the queue while adding complexity.
> This patch will be deferred until 3.19 due to some unbound patches
> are ready soon.
We're too late for this merge window anyway. This is a pretty
pervasive change after all.
Thanks.
--
tejun
next prev parent reply other threads:[~2014-07-30 3:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-26 3:04 [PATCH 0/3] workqueue: offload the worker-management out from kworker Lai Jiangshan
2014-07-26 3:04 ` [PATCH 1/3] workqueue: migrate the new worker before add it to idle_list Lai Jiangshan
2014-07-26 3:04 ` [PATCH 2/3] workqueue: use dedicated creater kthread for all pools Lai Jiangshan
2014-07-28 18:55 ` Tejun Heo
2014-07-29 1:26 ` Lai Jiangshan
2014-07-29 2:16 ` Tejun Heo
2014-07-29 9:16 ` [PATCH RFC 2/2 V2] " Lai Jiangshan
2014-07-29 15:04 ` Tejun Heo
2014-07-30 0:32 ` Lai Jiangshan
2014-07-30 3:23 ` Tejun Heo [this message]
2014-07-30 3:46 ` Lai Jiangshan
2014-07-30 3:46 ` Tejun Heo
2014-07-26 3:04 ` [PATCH 3/3] workqueue: cleanup may_start_working() Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140730032334.GA15787@htj.dyndns.org \
--to=tj@kernel.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox