From: Vinod Koul <vinod.koul@intel.com>
To: Alexander Popov <a13xp0p0v88@gmail.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] dmaengine: of: kconfig: select DMA_ENGINE when DMA_OF is selected
Date: Wed, 30 Jul 2014 19:08:06 +0530 [thread overview]
Message-ID: <20140730133806.GK8181@intel.com> (raw)
In-Reply-To: <1406721531-23635-1-git-send-email-a13xp0p0v88@gmail.com>
On Wed, Jul 30, 2014 at 03:58:51PM +0400, Alexander Popov wrote:
> Select DMA_ENGINE when DMA_OF is selected since
> of_dma_xlate_by_chan_id() from drivers/dma/of-dma.c uses
> dma_get_slave_channel() from drivers/dma/dmaengine.c
>
Please give credit to reporter by adding "Reported-by:" tag in commit
It is also got practice to give error log
> Signed-off-by: Alexander Popov <a13xp0p0v88@gmail.com>
Applied, now after adding reported tag and error log
--
~Vinod
> ---
> drivers/dma/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index 1eca7b9..f887b19 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -388,6 +388,7 @@ config DMA_ACPI
> config DMA_OF
> def_bool y
> depends on OF
> + select DMA_ENGINE
>
> comment "DMA Clients"
> depends on DMA_ENGINE
> --
> 1.8.4.2
>
--
next prev parent reply other threads:[~2014-07-30 13:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 11:58 [PATCH 1/1] dmaengine: of: kconfig: select DMA_ENGINE when DMA_OF is selected Alexander Popov
2014-07-30 13:38 ` Vinod Koul [this message]
2014-07-30 14:12 ` Alexander Popov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140730133806.GK8181@intel.com \
--to=vinod.koul@intel.com \
--cc=a13xp0p0v88@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox