* [PATCH 1/1] dmaengine: of: kconfig: select DMA_ENGINE when DMA_OF is selected
@ 2014-07-30 11:58 Alexander Popov
2014-07-30 13:38 ` Vinod Koul
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Popov @ 2014-07-30 11:58 UTC (permalink / raw)
To: Dan Williams, Vinod Koul, Alexander Popov, dmaengine,
linux-kernel
Select DMA_ENGINE when DMA_OF is selected since
of_dma_xlate_by_chan_id() from drivers/dma/of-dma.c uses
dma_get_slave_channel() from drivers/dma/dmaengine.c
Signed-off-by: Alexander Popov <a13xp0p0v88@gmail.com>
---
drivers/dma/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index 1eca7b9..f887b19 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -388,6 +388,7 @@ config DMA_ACPI
config DMA_OF
def_bool y
depends on OF
+ select DMA_ENGINE
comment "DMA Clients"
depends on DMA_ENGINE
--
1.8.4.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] dmaengine: of: kconfig: select DMA_ENGINE when DMA_OF is selected
2014-07-30 11:58 [PATCH 1/1] dmaengine: of: kconfig: select DMA_ENGINE when DMA_OF is selected Alexander Popov
@ 2014-07-30 13:38 ` Vinod Koul
2014-07-30 14:12 ` Alexander Popov
0 siblings, 1 reply; 3+ messages in thread
From: Vinod Koul @ 2014-07-30 13:38 UTC (permalink / raw)
To: Alexander Popov; +Cc: Dan Williams, dmaengine, linux-kernel
On Wed, Jul 30, 2014 at 03:58:51PM +0400, Alexander Popov wrote:
> Select DMA_ENGINE when DMA_OF is selected since
> of_dma_xlate_by_chan_id() from drivers/dma/of-dma.c uses
> dma_get_slave_channel() from drivers/dma/dmaengine.c
>
Please give credit to reporter by adding "Reported-by:" tag in commit
It is also got practice to give error log
> Signed-off-by: Alexander Popov <a13xp0p0v88@gmail.com>
Applied, now after adding reported tag and error log
--
~Vinod
> ---
> drivers/dma/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index 1eca7b9..f887b19 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -388,6 +388,7 @@ config DMA_ACPI
> config DMA_OF
> def_bool y
> depends on OF
> + select DMA_ENGINE
>
> comment "DMA Clients"
> depends on DMA_ENGINE
> --
> 1.8.4.2
>
--
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] dmaengine: of: kconfig: select DMA_ENGINE when DMA_OF is selected
2014-07-30 13:38 ` Vinod Koul
@ 2014-07-30 14:12 ` Alexander Popov
0 siblings, 0 replies; 3+ messages in thread
From: Alexander Popov @ 2014-07-30 14:12 UTC (permalink / raw)
To: Vinod Koul; +Cc: Dan Williams, dmaengine@vger.kernel.org, linux-kernel
2014-07-30 17:38 GMT+04:00 Vinod Koul <vinod.koul@intel.com>:
> On Wed, Jul 30, 2014 at 03:58:51PM +0400, Alexander Popov wrote:
>> Select DMA_ENGINE when DMA_OF is selected since
>> of_dma_xlate_by_chan_id() from drivers/dma/of-dma.c uses
>> dma_get_slave_channel() from drivers/dma/dmaengine.c
>>
> Please give credit to reporter by adding "Reported-by:" tag in commit
> It is also got practice to give error log
Ok, I got it.
>> Signed-off-by: Alexander Popov <a13xp0p0v88@gmail.com>
> Applied, now after adding reported tag and error log
Thanks, Vinod.
Best regards,
Alexander
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-30 14:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-30 11:58 [PATCH 1/1] dmaengine: of: kconfig: select DMA_ENGINE when DMA_OF is selected Alexander Popov
2014-07-30 13:38 ` Vinod Koul
2014-07-30 14:12 ` Alexander Popov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox