* Re: [PATCH] Staging: vt6655: staticfy variable
@ 2014-07-30 19:16 Guillaume Clement
2014-07-30 21:20 ` Fernando Apesteguía
0 siblings, 1 reply; 4+ messages in thread
From: Guillaume Clement @ 2014-07-30 19:16 UTC (permalink / raw)
To: Fernando Apesteguia; +Cc: gregkh, devel, linux-kernel, Tobias Klauser
Hello,
> Add static to variable.
> Signed-off-by: Fernando Apesteguia <fernando.apesteguia@gmail.com>
> ---
> drivers/staging/vt6655/ioctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/ioctl.c
> b/drivers/staging/vt6655/ioctl.c
> index 65e5933..cc6e47b 100644
> --- a/drivers/staging/vt6655/ioctl.c
> +++ b/drivers/staging/vt6655/ioctl.c
> @@ -41,7 +41,7 @@
> static int msglevel = MSG_LEVEL_INFO;
>
> #ifdef WPA_SM_Transtatus
> -SWPAResult wpa_Result;
> +static SWPAResult wpa_Result;
> #endif
This changes breaks the compilation (actually the linking). wpa_Result
is actually used in device_main.c in device_open with the following:
> #ifdef WPA_SM_Transtatus
> extern SWPAResult wpa_Result;
> #endif
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging: vt6655: staticfy variable
2014-07-30 19:16 [PATCH] Staging: vt6655: staticfy variable Guillaume Clement
@ 2014-07-30 21:20 ` Fernando Apesteguía
2014-07-31 0:04 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Fernando Apesteguía @ 2014-07-30 21:20 UTC (permalink / raw)
To: Guillaume Clement; +Cc: Greg KH, devel, linux-kernel, Tobias Klauser
On Wed, Jul 30, 2014 at 9:16 PM, Guillaume Clement <gclement@baobob.org> wrote:
> Hello,
>
>> Add static to variable.
>> Signed-off-by: Fernando Apesteguia <fernando.apesteguia@gmail.com>
>> ---
>> drivers/staging/vt6655/ioctl.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/vt6655/ioctl.c
>> b/drivers/staging/vt6655/ioctl.c
>> index 65e5933..cc6e47b 100644
>> --- a/drivers/staging/vt6655/ioctl.c
>> +++ b/drivers/staging/vt6655/ioctl.c
>> @@ -41,7 +41,7 @@
>> static int msglevel = MSG_LEVEL_INFO;
>>
>> #ifdef WPA_SM_Transtatus
>> -SWPAResult wpa_Result;
>> +static SWPAResult wpa_Result;
>> #endif
>
> This changes breaks the compilation (actually the linking). wpa_Result
> is actually used in device_main.c in device_open with the following:
Argh... sorry, I missed that.
>
>> #ifdef WPA_SM_Transtatus
>> extern SWPAResult wpa_Result;
>> #endif
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging: vt6655: staticfy variable
2014-07-30 21:20 ` Fernando Apesteguía
@ 2014-07-31 0:04 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2014-07-31 0:04 UTC (permalink / raw)
To: Fernando Apesteguía; +Cc: Guillaume Clement, devel, linux-kernel
On Wed, Jul 30, 2014 at 11:20:49PM +0200, Fernando Apesteguía wrote:
> On Wed, Jul 30, 2014 at 9:16 PM, Guillaume Clement <gclement@baobob.org> wrote:
> > Hello,
> >
> >> Add static to variable.
> >> Signed-off-by: Fernando Apesteguia <fernando.apesteguia@gmail.com>
> >> ---
> >> drivers/staging/vt6655/ioctl.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/staging/vt6655/ioctl.c
> >> b/drivers/staging/vt6655/ioctl.c
> >> index 65e5933..cc6e47b 100644
> >> --- a/drivers/staging/vt6655/ioctl.c
> >> +++ b/drivers/staging/vt6655/ioctl.c
> >> @@ -41,7 +41,7 @@
> >> static int msglevel = MSG_LEVEL_INFO;
> >>
> >> #ifdef WPA_SM_Transtatus
> >> -SWPAResult wpa_Result;
> >> +static SWPAResult wpa_Result;
> >> #endif
> >
> > This changes breaks the compilation (actually the linking). wpa_Result
> > is actually used in device_main.c in device_open with the following:
>
> Argh... sorry, I missed that.
ALWAYS test-build your patches, don't make me be your first tester...
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Staging: vt6655: staticfy variable
@ 2014-07-30 16:51 fernando.apesteguia
0 siblings, 0 replies; 4+ messages in thread
From: fernando.apesteguia @ 2014-07-30 16:51 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Fernando Apesteguia
From: Fernando Apesteguia <fernando.apesteguia@gmail.com>
Add static to variable.
Signed-off-by: Fernando Apesteguia <fernando.apesteguia@gmail.com>
---
drivers/staging/vt6655/ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/ioctl.c b/drivers/staging/vt6655/ioctl.c
index 65e5933..cc6e47b 100644
--- a/drivers/staging/vt6655/ioctl.c
+++ b/drivers/staging/vt6655/ioctl.c
@@ -41,7 +41,7 @@
static int msglevel = MSG_LEVEL_INFO;
#ifdef WPA_SM_Transtatus
-SWPAResult wpa_Result;
+static SWPAResult wpa_Result;
#endif
int private_ioctl(PSDevice pDevice, struct ifreq *rq)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-31 0:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-30 19:16 [PATCH] Staging: vt6655: staticfy variable Guillaume Clement
2014-07-30 21:20 ` Fernando Apesteguía
2014-07-31 0:04 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2014-07-30 16:51 fernando.apesteguia
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox