From: Peter Zijlstra <peterz@infradead.org>
To: "Yan, Zheng" <zheng.z.yan@intel.com>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
acme@infradead.org, eranian@google.com, andi@firstfloor.org
Subject: Re: [PATCH v4 0/9] perf, x86: large PEBS interrupt threshold
Date: Thu, 31 Jul 2014 09:49:38 +0200 [thread overview]
Message-ID: <20140731074938.GX9918@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <53D9F1FA.6080106@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1412 bytes --]
On Thu, Jul 31, 2014 at 03:36:26PM +0800, Yan, Zheng wrote:
> On 07/31/2014 03:27 PM, Peter Zijlstra wrote:
> >
> >
> > OK, so no feedback on the 'pending' discussions we had wrt PEBS record
> > generation?
> >
> > No feedback on the correctness aspects of the overflow crap?
> >
> > Just a new series, which I then have to dig through to figure out wtf
> > changed?
> >
> > A quick look at patch 6 reads like you still don't understand the issue
> > right. There are no 'collisions' as such in PEBS record generation, or
> > are there? See the earlier open discussion.
>
> I'm sure collision only create one PEBS records. Actually, the patch description
> was written by Andi.
So now Andi is contradicting himself:
http://marc.info/?l=linux-kernel&m=140129731708247&w=2
Bloody wonderful..
OK, so someone write down exactly how PEBS record generation works,
including the iffy overflow register, bring it to the relevant hardware
engineer, having him sign off on it, then come back.
And preferably add it to the next SDM rev. How is anybody to use this
stuff without knowing how it works?!
Let me try and figure out if actual collisions mean we cannot
reconstruct the actual events or not, you do the same.
Please file an internal bug report against that hardware (if there isn't
one already -- I've only been asking for this to get fixed for years
now).
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-07-31 7:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 6:44 [PATCH v4 0/9] perf, x86: large PEBS interrupt threshold Yan, Zheng
2014-07-31 6:44 ` [PATCH v4 1/9] perf, core: introduce pmu context switch callback Yan, Zheng
2014-07-31 6:44 ` [PATCH v4 2/9] perf, x86: use context switch callback to flush LBR stack Yan, Zheng
2014-07-31 6:44 ` [PATCH v4 3/9] perf, x86: use the PEBS auto reload mechanism when possible Yan, Zheng
2014-07-31 6:44 ` [PATCH v4 4/9] perf, x86: introduce setup_pebs_sample_data() Yan, Zheng
2014-07-31 6:45 ` [PATCH v4 5/9] perf, x86: large PEBS interrupt threshold Yan, Zheng
2014-07-31 6:45 ` [PATCH v4 6/9] perf, x86: handle multiple records in PEBS buffer Yan, Zheng
2014-07-31 6:45 ` [PATCH v4 7/9] perf, x86: drain PEBS buffer during context switch Yan, Zheng
2014-07-31 6:45 ` [PATCH v4 8/9] perf, x86: enlarge PEBS buffer Yan, Zheng
2014-07-31 6:45 ` [PATCH v4 9/9] tools, perf: Allow the user to disable time stamps Yan, Zheng
2014-07-31 14:45 ` Arnaldo Carvalho de Melo
2014-08-13 5:13 ` [tip:perf/core] perf record: Honour --no-time command line option tip-bot for Andi Kleen
2014-07-31 7:16 ` [PATCH v4 0/9] perf, x86: large PEBS interrupt threshold Ingo Molnar
2014-07-31 7:18 ` Yan, Zheng
2014-07-31 7:25 ` Ingo Molnar
2014-07-31 7:27 ` Peter Zijlstra
2014-07-31 7:36 ` Yan, Zheng
2014-07-31 7:49 ` Peter Zijlstra [this message]
2014-07-31 14:50 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140731074938.GX9918@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@infradead.org \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox