* [PATCH] Staging: rtl8192u: Staticfy debug method.
@ 2014-07-30 21:33 fernando.apesteguia
2014-07-31 0:05 ` Greg KH
2014-07-31 8:20 ` Dan Carpenter
0 siblings, 2 replies; 5+ messages in thread
From: fernando.apesteguia @ 2014-07-30 21:33 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Fernando Apesteguia
From: Fernando Apesteguia <fernando.apesteguia@gmail.com>
Add static to debug method.
Signed-off-by: Fernando Apesteguia <fernando.apesteguia@gmail.com>
---
drivers/staging/rtl8192u/r8192U_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
index 7640386..c732a67 100644
--- a/drivers/staging/rtl8192u/r8192U_core.c
+++ b/drivers/staging/rtl8192u/r8192U_core.c
@@ -667,7 +667,7 @@ static void tx_timeout(struct net_device *dev)
/* this is only for debug */
-void dump_eprom(struct net_device *dev)
+static void dump_eprom(struct net_device *dev)
{
int i;
for (i = 0; i < 63; i++)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: rtl8192u: Staticfy debug method.
2014-07-30 21:33 [PATCH] Staging: rtl8192u: Staticfy debug method fernando.apesteguia
@ 2014-07-31 0:05 ` Greg KH
2014-07-31 8:20 ` Dan Carpenter
1 sibling, 0 replies; 5+ messages in thread
From: Greg KH @ 2014-07-31 0:05 UTC (permalink / raw)
To: fernando.apesteguia; +Cc: devel, linux-kernel
On Wed, Jul 30, 2014 at 11:33:41PM +0200, fernando.apesteguia@gmail.com wrote:
> From: Fernando Apesteguia <fernando.apesteguia@gmail.com>
>
> Add static to debug method.
>
> Signed-off-by: Fernando Apesteguia <fernando.apesteguia@gmail.com>
> ---
> drivers/staging/rtl8192u/r8192U_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
> index 7640386..c732a67 100644
> --- a/drivers/staging/rtl8192u/r8192U_core.c
> +++ b/drivers/staging/rtl8192u/r8192U_core.c
> @@ -667,7 +667,7 @@ static void tx_timeout(struct net_device *dev)
>
>
> /* this is only for debug */
> -void dump_eprom(struct net_device *dev)
> +static void dump_eprom(struct net_device *dev)
> {
> int i;
> for (i = 0; i < 63; i++)
Someone sent this patch just before you :(
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: rtl8192u: Staticfy debug method.
2014-07-30 21:33 [PATCH] Staging: rtl8192u: Staticfy debug method fernando.apesteguia
2014-07-31 0:05 ` Greg KH
@ 2014-07-31 8:20 ` Dan Carpenter
2014-07-31 9:10 ` Fernando Apesteguía
1 sibling, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2014-07-31 8:20 UTC (permalink / raw)
To: fernando.apesteguia; +Cc: gregkh, devel, linux-kernel
You need to compile these things before sending them...
This adds a GCC warning about uncalled functions.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: rtl8192u: Staticfy debug method.
2014-07-31 8:20 ` Dan Carpenter
@ 2014-07-31 9:10 ` Fernando Apesteguía
2014-07-31 10:22 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Fernando Apesteguía @ 2014-07-31 9:10 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Greg KH, linux-kernel, devel
El 31/07/2014 10:21, "Dan Carpenter" <dan.carpenter@oracle.com> escribió:
>
> You need to compile these things before sending them...
>
> This adds a GCC warning about uncalled functions.
Sorry, but I did compile it with
make C=1 M=drivers/staging
But for the function to be called, DEBUG_EPROM must be defined and I
had it defined. That's why I overlooked the warning.
Apologies.
>
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: rtl8192u: Staticfy debug method.
2014-07-31 9:10 ` Fernando Apesteguía
@ 2014-07-31 10:22 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2014-07-31 10:22 UTC (permalink / raw)
To: Fernando Apesteguía; +Cc: devel, Greg KH, linux-kernel
On Thu, Jul 31, 2014 at 11:10:33AM +0200, Fernando Apesteguía wrote:
> El 31/07/2014 10:21, "Dan Carpenter" <dan.carpenter@oracle.com> escribió:
> >
> > You need to compile these things before sending them...
> >
> > This adds a GCC warning about uncalled functions.
>
> Sorry, but I did compile it with
>
> make C=1 M=drivers/staging
>
> But for the function to be called, DEBUG_EPROM must be defined and I
> had it defined. That's why I overlooked the warning.
Ah. Ok.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-07-31 10:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-30 21:33 [PATCH] Staging: rtl8192u: Staticfy debug method fernando.apesteguia
2014-07-31 0:05 ` Greg KH
2014-07-31 8:20 ` Dan Carpenter
2014-07-31 9:10 ` Fernando Apesteguía
2014-07-31 10:22 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox