From: Aaron Lu <aaron.lu@intel.com>
To: Mel Gorman <mgorman@suse.de>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
LKML <linux-kernel@vger.kernel.org>,
lkp@01.org
Subject: Re: [LKP] [mm] b72fd1470c9: -41.7% perf-profile.cpu-cycles.get_page_from_freelist.__alloc_pages_nodemask.alloc_pages_current.__page_cache_alloc.pagecache_get_page
Date: Thu, 31 Jul 2014 17:01:30 +0800 [thread overview]
Message-ID: <20140731090130.GB23367@aaronlu.sh.intel.com> (raw)
In-Reply-To: <20140731084832.GP10819@suse.de>
On Thu, Jul 31, 2014 at 09:48:32AM +0100, Mel Gorman wrote:
> On Thu, Jul 31, 2014 at 01:50:35PM +0800, Aaron Lu wrote:
> > FYI, we noticed the below changes on
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > commit b72fd1470c9735f53485d089aa918dc327a86077 ("mm: rearrange zone fields into read-only, page alloc, statistics and page reclaim lines")
> >
> > test case: lkp-st02/dd-write/5m-11HDD-JBOD-cfq-xfs-10dd
> >
> > e28c951ff01a805 b72fd1470c9735f53485d089a
> > --------------- -------------------------
> > 1.06 ~ 6% -41.7% 0.62 ~ 3% TOTAL perf-profile.cpu-cycles.get_page_from_freelist.__alloc_pages_nodemask.alloc_pages_current.__page_cache_alloc.pagecache_get_page
> > 1.34 ~ 2% -19.8% 1.07 ~ 2% TOTAL perf-profile.cpu-cycles.__block_write_begin.xfs_vm_write_begin.generic_perform_write.xfs_file_buffered_aio_write.xfs_file_write_iter
> > 1.19 ~ 5% -12.1% 1.05 ~ 4% TOTAL perf-profile.cpu-cycles.copy_from_user_atomic_iovec.iov_iter_copy_from_user_atomic.generic_perform_write.xfs_file_buffered_aio_write.xfs_file_write_iter
> > 2.78 ~ 1% -16.3% 2.32 ~ 4% TOTAL perf-profile.cpu-cycles.__clear_user.read_zero.read_zero.vfs_read.sys_read
> > 2.96e+09 ~ 4% -5.2% 2.806e+09 ~ 0% TOTAL perf-stat.cache-misses
> > 3.86e+12 ~ 5% -5.2% 3.658e+12 ~ 1% TOTAL perf-stat.ref-cycles
> >
> > Legend:
> > ~XX% - stddev percent
> > [+-]XX% - change percent
> >
>
> I'm not exactly sure what I'm reading here. I think it is reporting on cpu
> cycles and cache misses used in various kernel functions. It's not clear what
> the units are but it looks like percentages of overall cycles spent in the
> reported functions. That may or may not be good depending on whether there
> is a higher cost elsewhere pushing the percentages down but that detail
> is not in the report. It looks like this is reporting that fewer clock
> cycles are being spent and incurring fewer cache misses. What is the problem?
LKP does not report problems only, it will also report commits that make
things better :-)
>From the perf-stat.cache-misses, I think it is indicating your commit
does something for good.
Thanks,
Aaron
next prev parent reply other threads:[~2014-07-31 9:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 5:50 [LKP] [mm] b72fd1470c9: -41.7% perf-profile.cpu-cycles.get_page_from_freelist.__alloc_pages_nodemask.alloc_pages_current.__page_cache_alloc.pagecache_get_page Aaron Lu
2014-07-31 8:48 ` Mel Gorman
2014-07-31 9:01 ` Aaron Lu [this message]
2014-07-31 9:32 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140731090130.GB23367@aaronlu.sh.intel.com \
--to=aaron.lu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=mgorman@suse.de \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox