From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753435AbaHABaq (ORCPT ); Thu, 31 Jul 2014 21:30:46 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:37436 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753065AbaHABao (ORCPT ); Thu, 31 Jul 2014 21:30:44 -0400 X-Originating-IP: 50.43.15.134 Date: Thu, 31 Jul 2014 18:30:30 -0700 From: Josh Triplett To: NeilBrown Cc: akpm@linux-foundation.org, "J. Bruce Fields" , Alexander Viro , Christopher Li , Ingo Molnar , Jeff Layton , Michal Marek , Steven Rostedt , linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, linux-sparse@vger.kernel.org Subject: Re: [PATCH 2/5] raid: Require designated initialization of structures Message-ID: <20140801013030.GA20935@thin> References: <3130b0553b15518e3bef6d14c80280beed0f5ff9.1406850006.git.josh@joshtriplett.org> <1d468224409ef2bf46874f817d19389ac5d1b26d.1406850006.git.josh@joshtriplett.org> <20140801111055.59419950@notabene.brown> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140801111055.59419950@notabene.brown> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 01, 2014 at 11:10:55AM +1000, NeilBrown wrote: > On Thu, 31 Jul 2014 16:47:35 -0700 Josh Triplett > wrote: > > > Mark raid6_calls and other structures containing function pointers with > > __designated_init. Fix implementations in lib/raid6/ to use designated > > initializers; this also simplifies those initializers using the default > > initialization of fields to 0. > > > > Signed-off-by: Josh Triplett > > Looks like an excellent idea! > Feel free to forward this upstream on my behalf, or remind me once the first > patch is in -next, and I'll take this one myself - whichever you prefer. > > Acked-by: NeilBrown Thanks! Ideally, I'd like to see the whole series go in through one tree, which is why I CCed Andrew. I can easily produce several dozen more patches like these, but I just included enough examples to motivate patch 1, and I can send more in any order once that one goes in. - Josh Triplett