From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Vincent Bernat <vincent@bernat.im>
Cc: Benjamin Romer <benjamin.romer@unisys.com>,
David Kershner <david.kershner@unisys.com>,
sparmaintainer@unisys.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: visorchipset: fix sparse warnings about static declaration
Date: Fri, 1 Aug 2014 01:15:37 -0700 [thread overview]
Message-ID: <20140801081537.GA920@kroah.com> (raw)
In-Reply-To: <1406880622-12324-1-git-send-email-vincent@bernat.im>
On Fri, Aug 01, 2014 at 10:10:22AM +0200, Vincent Bernat wrote:
> Some functions were prototyped as static but the actual definition
> wasn't. While this is valid (the function is static because the two
> declarations don't conflict and the first one is static), this makes
> sparse unhappy and cause confusion of normal people too.
>
> Signed-off-by: Vincent Bernat <vincent@bernat.im>
> ---
> .../unisys/visorchipset/visorchipset_main.c | 22 +++++++++++++---------
> 1 file changed, 13 insertions(+), 9 deletions(-)
This no longer applies cleanly to my tree, can you please refresh it and
resend so that I can apply it?
thanks,
greg k-h
next prev parent reply other threads:[~2014-08-01 8:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 8:10 [PATCH] staging: visorchipset: fix sparse warnings about static declaration Vincent Bernat
2014-08-01 8:15 ` Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-08-01 8:29 Vincent Bernat
2014-07-27 21:02 Vincent Bernat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140801081537.GA920@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=benjamin.romer@unisys.com \
--cc=david.kershner@unisys.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sparmaintainer@unisys.com \
--cc=vincent@bernat.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox