From: Christoph Hellwig <hch@infradead.org>
To: jgross@suse.com
Cc: JBottomley@parallels.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Save command pool address of Scsi_Host
Date: Fri, 1 Aug 2014 05:03:01 -0700 [thread overview]
Message-ID: <20140801120301.GA27198@infradead.org> (raw)
In-Reply-To: <1406874425-3528-1-git-send-email-jgross@suse.com>
On Fri, Aug 01, 2014 at 08:27:05AM +0200, jgross@suse.com wrote:
> From: Juergen Gross <jgross@suse.com>
>
> If a scsi host driver specifies .cmd_len in it's scsi_host_template, a driver's
> private command pool is needed. scsi_find_host_cmd_pool() will locate it, but
> scsi_alloc_host_cmd_pool() isn't saving the pool address in the host template.
>
> This will result in an access error when the host is removed.
>
> Avoid the problem by saving the address of a new allocated command pool where
> it is expected.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
Looks good, but minor nitpick below:
> + if (shost->hostt->cmd_size)
> + shost->hostt->cmd_pool = pool;
> +
We already have a local hostt variable for the host template in this
function, please use it.
next prev parent reply other threads:[~2014-08-01 12:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 6:27 [PATCH] Save command pool address of Scsi_Host jgross
2014-08-01 12:03 ` Christoph Hellwig [this message]
2014-08-01 20:24 ` James Bottomley
2014-08-04 4:22 ` Juergen Gross
2014-08-04 11:03 ` Christoph Hellwig
2014-08-04 14:31 ` James Bottomley
2014-08-04 11:07 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140801120301.GA27198@infradead.org \
--to=hch@infradead.org \
--cc=JBottomley@parallels.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).