From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755101AbaHAMDH (ORCPT ); Fri, 1 Aug 2014 08:03:07 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:56624 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754155AbaHAMDF (ORCPT ); Fri, 1 Aug 2014 08:03:05 -0400 Date: Fri, 1 Aug 2014 05:03:01 -0700 From: Christoph Hellwig To: jgross@suse.com Cc: JBottomley@parallels.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Save command pool address of Scsi_Host Message-ID: <20140801120301.GA27198@infradead.org> References: <1406874425-3528-1-git-send-email-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1406874425-3528-1-git-send-email-jgross@suse.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 01, 2014 at 08:27:05AM +0200, jgross@suse.com wrote: > From: Juergen Gross > > If a scsi host driver specifies .cmd_len in it's scsi_host_template, a driver's > private command pool is needed. scsi_find_host_cmd_pool() will locate it, but > scsi_alloc_host_cmd_pool() isn't saving the pool address in the host template. > > This will result in an access error when the host is removed. > > Avoid the problem by saving the address of a new allocated command pool where > it is expected. > > Signed-off-by: Juergen Gross Looks good, but minor nitpick below: > + if (shost->hostt->cmd_size) > + shost->hostt->cmd_pool = pool; > + We already have a local hostt variable for the host template in this function, please use it.