From: Thomas Graf <tgraf@suug.ch>
To: Patrick McHardy <kaber@trash.net>
Cc: Nikolay Aleksandrov <nikolay@redhat.com>,
davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, paulmck@linux.vnet.ibm.com,
josh@joshtriplett.org, challa@noironetworks.com,
walpole@cs.pdx.edu, dev@openvswitch.org, tklauser@distanz.ch,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH net-next 3/3] nftables: Convert nft_hash to use generic rhashtable
Date: Fri, 1 Aug 2014 15:51:45 +0100 [thread overview]
Message-ID: <20140801145145.GE7331@casper.infradead.org> (raw)
In-Reply-To: <0d77fb6a-4465-432f-9d6a-b1c1497a780b@email.android.com>
On 08/01/14 at 03:12pm, Patrick McHardy wrote:
> On 1. August 2014 14:49:01 GMT+01:00, Thomas Graf <tgraf@suug.ch> wrote:
> >On 08/01/14 at 02:21pm, Nikolay Aleksandrov wrote:
> >> Sorry for the late response but I just got around to check the 3rd
> >patch now,
> >> so my question about this fragment is: before nft_hash_remove() would
> >free the
> >> element after removal, but after this change I don't see where and
> >when the
> >> removed element would get freed ?
> >
> >You are right. Looking at this closer we were leaking references even
> >before the change because it would not call nft_data_uninit() to
> >release
> >the data objects. So it should really just call
> >nft_hash_elem_destroy().
>
> No, the data uninit is performed by the set core. Just freeing it is fine.
OK, I can see the uninit on the data in nft_del_setelem() for maps
prior to the actual commit. The location is slightly unexpected since
the element is still findable in the hash table at that point.
I'll wait a short while to see if there is more feedback and resubmit
afterwards.
next prev parent reply other threads:[~2014-08-01 14:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 11:58 [PATCH net-next v4 0/3] Lockless netlink_lookup() with new concurrent hash table Thomas Graf
2014-08-01 11:58 ` [PATCH net-next 1/3] lib: Resizable, Scalable, Concurrent Hash Table Thomas Graf
2014-08-01 11:58 ` [PATCH net-next 2/3] netlink: Convert netlink_lookup() to use RCU protected hash table Thomas Graf
2014-08-01 14:51 ` Nikolay Aleksandrov
2014-08-01 15:15 ` Thomas Graf
2014-08-01 15:20 ` Nikolay Aleksandrov
2014-08-01 11:58 ` [PATCH net-next 3/3] nftables: Convert nft_hash to use generic rhashtable Thomas Graf
2014-08-01 12:21 ` Nikolay Aleksandrov
2014-08-01 13:49 ` Thomas Graf
2014-08-01 14:12 ` Patrick McHardy
2014-08-01 14:51 ` Thomas Graf [this message]
2014-08-01 15:00 ` Patrick McHardy
-- strict thread matches above, loose matches on Subject: below --
2014-08-02 9:47 [PATCH net-next v5 0/3] Lockless netlink_lookup() with new concurrent hash table Thomas Graf
2014-08-02 9:47 ` [PATCH net-next 3/3] nftables: Convert nft_hash to use generic rhashtable Thomas Graf
2014-08-02 10:56 ` Nikolay Aleksandrov
2014-08-01 8:51 [PATCH net-next v3 0/3] Lockless netlink_lookup() with new concurrent hash table Thomas Graf
2014-08-01 8:52 ` [PATCH net-next 3/3] nftables: Convert nft_hash to use generic rhashtable Thomas Graf
2014-08-01 10:17 ` Patrick McHardy
2014-08-01 10:39 ` Thomas Graf
2014-08-01 10:47 ` Patrick McHardy
2014-07-31 22:56 [PATCH v2 0/3 net-next] Lockless netlink_lookup() with new concurrent hash table Thomas Graf
2014-07-31 22:56 ` [PATCH net-next 3/3] nftables: Convert nft_hash to use generic rhashtable Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140801145145.GE7331@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=challa@noironetworks.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=josh@joshtriplett.org \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nikolay@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tklauser@distanz.ch \
--cc=walpole@cs.pdx.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).