public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Jirka Hladky <jhladky@redhat.com>
Cc: Rik van Riel <riel@redhat.com>, Aaron Lu <aaron.lu@intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	lkp@01.org
Subject: Re: [LKP] [sched/numa] a43455a1d57: +94.1% proc-vmstat.numa_hint_faults_local
Date: Fri, 1 Aug 2014 17:02:46 +0200	[thread overview]
Message-ID: <20140801150246.GC3588@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20140731173705.GC19379@twins.programming.kicks-ass.net>

[-- Attachment #1: Type: text/plain, Size: 1461 bytes --]

On Thu, Jul 31, 2014 at 07:37:05PM +0200, Peter Zijlstra wrote:
> On Thu, Jul 31, 2014 at 06:39:05PM +0200, Jirka Hladky wrote:
> > I'm doing 3 iterations (3 runs) to get some statistics. To speed up the test
> > significantly please do the run with 20 warehouses only
> > (or in general with #warehouses ==  number of nodes * number of PHYSICAL
> > cores)
> 
> Yeah, went and did that for my 4 node machine, its got a ton more cores, but I
> matches the warehouses to it:
> 
> -a43455a1d57	tip/master
> 
> 979996.47	1144715.44
> 876146		1098499.07
> 1058974.18	1019499.38
> 1055951.59	1139405.22
> 970504.01	1099659.09
> 
> 988314.45	1100355.64	(avg)
> 75059.546179565	50085.7473975167(stdev)
> 
> So for 5 runs, tip/master (which includes the offending patch) wins hands down.
> 
> Each run is 2 minutes.

Because Rik asked for a43455a1d57^1 numbers:

546423.08
546558.63
545990.01
546015.98

some a43455a1d57 numbers:

538652.93
544333.57
542684.77

same setup and everything. So clearly the patches after that made 'some'
difference indeed, seeing how tip/master is almost twice that.

So the reason I didn't so a43455a1d57^1 vs a43455a1d57 is because we already
fingered a commit, after that what you test is the revert of that commit,
because revert is what you typically end up doing if a commit is fail.

But on the state of tip/master, taking that commit out is a net negative for
everything I've tested.

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2014-08-01 15:03 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <53d70ee6.JsUEmW5dWsv8dev+%fengguang.wu@intel.com>
2014-07-29  5:24 ` [LKP] [sched/numa] a43455a1d57: +94.1% proc-vmstat.numa_hint_faults_local Aaron Lu
2014-07-29  6:39   ` Rik van Riel
2014-07-29  8:17     ` Peter Zijlstra
2014-07-29 20:04       ` Rik van Riel
2014-07-30  2:14         ` Aaron Lu
2014-07-30 14:25           ` Rik van Riel
2014-07-31  5:04             ` Aaron Lu
2014-07-31  6:22               ` Rik van Riel
2014-07-31  6:53                 ` Aaron Lu
2014-07-31  6:42               ` Rik van Riel
2014-08-05 21:43               ` Rik van Riel
2014-07-31  8:33           ` Peter Zijlstra
2014-07-31  8:56             ` Aaron Lu
2014-07-31 10:42     ` Peter Zijlstra
2014-07-31 15:57       ` Peter Zijlstra
2014-07-31 16:16         ` Jirka Hladky
2014-07-31 16:27           ` Peter Zijlstra
2014-07-31 16:39             ` Jirka Hladky
2014-07-31 17:37               ` Peter Zijlstra
2014-08-01 15:02                 ` Peter Zijlstra [this message]
2014-08-01 20:46           ` Davidlohr Bueso
2014-08-01 20:48             ` Davidlohr Bueso
2014-08-01 21:30             ` Jirka Hladky
2014-08-02  4:17               ` Rik van Riel
2014-08-02  5:28                 ` Jirka Hladky
2014-08-02  4:26               ` Peter Zijlstra
2014-08-01  0:18       ` Davidlohr Bueso
2014-08-01  2:03       ` Aaron Lu
2014-08-01  4:03         ` Davidlohr Bueso
2014-08-01  7:29           ` Peter Zijlstra
2014-08-01  7:29         ` Peter Zijlstra
2014-07-31 23:58           ` Yuyang Du
2014-08-01  8:14           ` Fengguang Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140801150246.GC3588@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=aaron.lu@intel.com \
    --cc=jhladky@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@01.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox