From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andi Kleen <andi@firstfloor.org>,
kan.liang@intel.com, alexander.shishkin@linux.intel.com,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 2/3] x86 perf: Protect LBR msrs accessing against potential #GP
Date: Sat, 2 Aug 2014 07:27:26 +0200 [thread overview]
Message-ID: <20140802052726.GB14766@gmail.com> (raw)
In-Reply-To: <20140801185057.GK19379@twins.programming.kicks-ass.net>
* Peter Zijlstra <peterz@infradead.org> wrote:
> > > I yelled at BIOS engineers over their PMU usage and $vendor
> > > added a BIOS knob to disable that, I'll yell at BIOS engineers
> > > again, just give me their number.
> > >
> > > Really, say NO already.
> >
> > Ok, so no technical reason, merely a "me vs you" power play.
Andi, stop the silly arguments already and stop launching personal
attacks against maintainers who are simply doing their job!
> Clearly you forgot the discussion we had back then, you want me to
> find you a link or do you think you can Google it yourself? I'm not
> the only one who thinks its a terrible idea for the BIOS to involve
> itself in these things.
The BIOS has no business stealing or meddling with limited resources
used by and managed by the kernel, such as PMU state. In addition to
the loss of utility to users when the BIOS interferes, PMUs are buggy
and fragile enough even without any undue BIOS interference.
This was escallated up to Linus last time around and he agreed that
such BIOS meddling with kernel state is not acceptable, so you'll
probably have to convince him as well in addition to having to
convince every perf and x86 maintainer.
Ingo
next prev parent reply other threads:[~2014-08-02 5:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 9:41 [PATCH 1/3] x86 msr: msr goto extension support kan.liang
2014-07-31 9:41 ` [PATCH 2/3] x86 perf: Protect LBR msrs accessing against potential #GP kan.liang
2014-08-01 7:38 ` Peter Zijlstra
2014-08-01 7:44 ` Peter Zijlstra
2014-08-01 13:21 ` Andi Kleen
2014-08-01 18:50 ` Peter Zijlstra
2014-08-02 5:27 ` Ingo Molnar [this message]
2014-07-31 9:41 ` [PATCH 3/3] x86 perf: Protect LBR and BTS enabling kan.liang
2014-07-31 21:05 ` [PATCH 1/3] x86 msr: msr goto extension support Andy Lutomirski
2014-08-01 8:05 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140802052726.GB14766@gmail.com \
--to=mingo@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).