From: Jean Delvare <jdelvare@suse.de>
To: kreijack@inwind.it
Cc: kreijack@gmail.com,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-kernel@vger.kernel.org, bryan@whatroute.net
Subject: Re: [PATCH 3/4] Add the "verbose" module option.
Date: Sun, 3 Aug 2014 17:52:22 +0200 [thread overview]
Message-ID: <20140803175222.3433b646@endymion.delvare> (raw)
In-Reply-To: <53DE5179.3080402@gmail.com>
On Sun, 03 Aug 2014 17:12:57 +0200, Goffredo Baroncelli wrote:
> On 08/03/2014 04:12 PM, Jean Delvare wrote:
> >> + (verbose > 0 && level >= 0)) {
> >> + print_temp("CPU-temp: ", temp );
> >> + if (casetemp)
> >> + print_temp(", Case: ", casetemp );
> >> + if (level >= 0)
> >> + printk(", Fan: %d (tuned %+d)\n", 11-level,
> >> + x.fan_level-level );
> >> + else
> >> + printk(", Fan: %d (tuned +0)\n",x.fan_level);
> >
> > I think you can do without the "tuned +0" which doesn't add much value.
>
> Me too. But the old driver does the same, so I preferred to
> leave it as is.
I looked at the code again and no, I can't see the old code doing that.
It has "tuned %+d" only in tune_fan() which is only called if
level >= 0. The other printk (when tune_fan isn't called) doesn't have
a "tuned" part.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2014-08-03 15:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 14:00 [PATCH][v2] therm_windtunnel doesn't work properly on PowerMac G4 Goffredo Baroncelli
2014-08-01 14:00 ` [PATCH 1/4] Update drivers names to the ones invoked by i2c-powermac Goffredo Baroncelli
2014-08-01 14:00 ` [PATCH 2/4] Remove attach_method because un-used Goffredo Baroncelli
2014-08-01 14:00 ` [PATCH 3/4] Add the "verbose" module option Goffredo Baroncelli
2014-08-03 14:12 ` Jean Delvare
2014-08-03 15:12 ` Goffredo Baroncelli
2014-08-03 15:52 ` Jean Delvare [this message]
2014-08-03 16:36 ` Goffredo Baroncelli
2014-08-04 8:46 ` Jean Delvare
2014-08-04 17:10 ` Goffredo Baroncelli
2014-08-05 8:59 ` Jean Delvare
2014-08-01 14:00 ` [PATCH 4/4] Return the fan speed via sysfs Goffredo Baroncelli
2014-08-03 14:17 ` Jean Delvare
2014-08-03 15:27 ` Goffredo Baroncelli
2014-08-03 15:59 ` Jean Delvare
2014-08-03 16:42 ` Goffredo Baroncelli
2014-08-04 8:44 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140803175222.3433b646@endymion.delvare \
--to=jdelvare@suse.de \
--cc=benh@kernel.crashing.org \
--cc=bryan@whatroute.net \
--cc=kreijack@gmail.com \
--cc=kreijack@inwind.it \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox