From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751801AbaHDH5K (ORCPT ); Mon, 4 Aug 2014 03:57:10 -0400 Received: from mail.skyhub.de ([78.46.96.112]:51816 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751772AbaHDH5I (ORCPT ); Mon, 4 Aug 2014 03:57:08 -0400 Date: Mon, 4 Aug 2014 09:57:00 +0200 From: Borislav Petkov To: Denys Vlasenko Cc: Frederic Weisbecker , Denys Vlasenko , Linux Kernel Mailing List , Oleg Nesterov , "H. Peter Anvin" , Andy Lutomirski , X86 ML , Alexei Starovoitov , Will Drewry , Kees Cook Subject: Re: [PATCH 4/5] x86: entry_64.S: always allocate complete "struct pt_regs" Message-ID: <20140804075700.GA31543@pd.tnic> References: <1406904498-21647-1-git-send-email-dvlasenk@redhat.com> <1406904498-21647-4-git-send-email-dvlasenk@redhat.com> <20140801231929.GB26491@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 04, 2014 at 05:03:42AM +0200, Denys Vlasenko wrote: > I changed this entire area in v2: basically, I will not change the > logic, but will add comments explaining what are we doing here, and > why. Very good idea! This file needs some good commenting. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --