From: Vinod Koul <vinod.koul@intel.com>
To: Vignesh Raman <Vignesh_Raman@mentor.com>
Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, Jiada_Wang@mentor.com
Subject: Re: [PATCH 1/2] dma: imx-sdma: use module_platform_driver for SDMA driver
Date: Mon, 4 Aug 2014 14:08:23 +0530 [thread overview]
Message-ID: <20140804083823.GO8181@intel.com> (raw)
In-Reply-To: <53DF471D.70407@mentor.com>
On Mon, Aug 04, 2014 at 02:11:01PM +0530, Vignesh Raman wrote:
> On Thursday 31 July 2014 05:30 PM, Vinod Koul wrote:
> > On Wed, Jul 30, 2014 at 06:41:14PM +0530, Vignesh Raman wrote:
> >> Currently there is no module_exit declared in SDMA driver, so that once
> >> sdma module is inserted, it's shown with permanent attribute by lsmod,
> >> and it can't be removed.
> >> Use module_platform_driver to register/unregister SDMA driver and modify
> >> SDMA's remove operation, to make SDMA driver possible to be removed.
> > where is this bit below?
> >
> I'm not clear with your question. Are you asking about the unregister
> SDMA driver function? It is done by dma_async_device_unregister.
Driver already uses module_platform_driver, so I dont see what information
the last two lines are trying to convey.
Patch needs to talk about what is done in current patch
--
~Vinod
next prev parent reply other threads:[~2014-08-04 8:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 13:11 [PATCH 0/2] dma: imx-sdma: Modify SDMA's remove operation Vignesh Raman
2014-07-30 13:11 ` [PATCH 1/2] dma: imx-sdma: use module_platform_driver for SDMA driver Vignesh Raman
2014-07-31 12:00 ` Vinod Koul
2014-08-04 8:41 ` Vignesh Raman
2014-08-04 8:38 ` Vinod Koul [this message]
2014-08-05 6:27 ` Vignesh Raman
2014-07-30 13:11 ` [PATCH 2/2] dma: imx-sdma: Adding tasklet_kill() in sdma_remove function Vignesh Raman
2014-07-31 12:02 ` Vinod Koul
2014-08-01 14:06 ` Vignesh Raman
2014-08-01 16:45 ` Vinod Koul
2014-08-04 8:34 ` Vignesh Raman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140804083823.GO8181@intel.com \
--to=vinod.koul@intel.com \
--cc=Jiada_Wang@mentor.com \
--cc=Vignesh_Raman@mentor.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).