From: Karel Zak <kzak@redhat.com>
To: Davidlohr Bueso <davidlohr@hp.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Linux Containers <containers@lists.linux-foundation.org>,
linux-api@vger.kernel.org,
"Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [REVIEW][PATCH 0/4] /proc/thread-self
Date: Mon, 4 Aug 2014 15:12:49 +0200 [thread overview]
Message-ID: <20140804131249.GD6923@x2.net.home> (raw)
In-Reply-To: <1406860795.3036.3.camel@buesod1.americas.hpqcorp.net>
On Thu, Jul 31, 2014 at 07:39:55PM -0700, Davidlohr Bueso wrote:
> On Thu, 2014-07-31 at 17:30 -0700, Eric W. Biederman wrote:
> > This is small chance changing /proc/net and /proc/mounts will cause
> > userspace regressions (although nothing has shown up in my testing) if
> > that happens we can just point the change that moves them from
> > /proc/self/... to /proc/thread-self/...
>
> Isn't breaking userspace a no no, no matter what? At least some
> util-linux programs makes use of both /proc/mounts and /proc/net.
Frankly, I don't care about /proc/mount, this file is more about backward
compatibility than about any real informations ;-)
The really important file is /proc/self/mountinfo. We use this file on
many places including shared libs and it seems (according to Eric's
suggestion), that the right think will be to update the libs to use
/proc/thread-self/mountinfo.
Note that I like the idea to have the magic symlink to access thread
specific /proc stuff. It's definitely nice thing for userspace.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2014-08-04 13:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 0:30 [REVIEW][PATCH 0/4] /proc/thread-self Eric W. Biederman
2014-08-01 0:33 ` [REVIEW][PATCH 1/4] proc: Have net show up under /proc/<tgid>/task/<tid> Eric W. Biederman
2014-08-01 0:34 ` [REVIEW][PATCH 2/4] proc: Implement /proc/thread-self to point at the directory of the current thread Eric W. Biederman
2014-08-06 14:35 ` Serge E. Hallyn
2014-08-06 18:22 ` Eric W. Biederman
2014-08-06 18:32 ` Serge Hallyn
2014-08-01 0:34 ` [REVIEW][PATCH 3/4] proc: Point /proc/net at /proc/thread-self/net instead of /proc/self/net Eric W. Biederman
2014-08-01 0:35 ` [REVIEW][PATCH 4/4] proc: Point /proc/mounts at /proc/thread-self/mounts instead of /proc/self/mounts Eric W. Biederman
2014-08-01 2:39 ` [REVIEW][PATCH 0/4] /proc/thread-self Davidlohr Bueso
2014-08-01 6:16 ` Eric W. Biederman
2014-08-04 13:12 ` Karel Zak [this message]
2014-08-01 6:45 ` Randy Dunlap
2014-08-01 7:01 ` Eric W. Biederman
2014-08-01 7:14 ` Bert Wesarg
2014-08-01 7:45 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140804131249.GD6923@x2.net.home \
--to=kzak@redhat.com \
--cc=containers@lists.linux-foundation.org \
--cc=davidlohr@hp.com \
--cc=ebiederm@xmission.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox