From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753231AbaHDWZh (ORCPT ); Mon, 4 Aug 2014 18:25:37 -0400 Received: from imap.thunk.org ([74.207.234.97]:44232 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753176AbaHDWZe (ORCPT ); Mon, 4 Aug 2014 18:25:34 -0400 Date: Mon, 4 Aug 2014 18:25:21 -0400 From: "Theodore Ts'o" To: Andy Lutomirski Cc: kvm@vger.kernel.org, "H. Peter Anvin" , linux-kernel@vger.kernel.org, Kees Cook , x86@kernel.org, Daniel Borkmann , Srivatsa Vaddagiri , Raghavendra K T , Gleb Natapov , Paolo Bonzini , bsd@redhat.com, Andrew Honig Subject: Re: [PATCH v5 2/5] random: Add and use arch_get_rng_seed Message-ID: <20140804222521.GB5263@thunk.org> Mail-Followup-To: Theodore Ts'o , Andy Lutomirski , kvm@vger.kernel.org, "H. Peter Anvin" , linux-kernel@vger.kernel.org, Kees Cook , x86@kernel.org, Daniel Borkmann , Srivatsa Vaddagiri , Raghavendra K T , Gleb Natapov , Paolo Bonzini , bsd@redhat.com, Andrew Honig References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 23, 2014 at 09:57:28PM -0700, Andy Lutomirski wrote: > Currently, init_std_data contains its own logic for using arch > random sources. This replaces that logic with a generic function > arch_get_rng_seed that allows arch code to supply its own logic. > The default implementation tries arch_get_random_seed_long and > arch_get_random_long individually. > > The only functional change here is that random_get_entropy() is used > unconditionally instead of being used only when the arch sources > fail. This may add a tiny amount of security. > > Signed-off-by: Andy Lutomirski Acked-by: Theodore Ts'o - Ted