From: Wanpeng Li <wanpeng.li@linux.intel.com>
To: Davidlohr Bueso <davidlohr@hp.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Gleb Natapov <gleb@kernel.org>, Bandan Das <bsd@redhat.com>,
Zhang Yang <yang.z.zhang@intel.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
freyes@suse.com
Subject: Re: [PATCH 1/2] KVM: nVMX: Fix nested vmexit ack intr before load vmcs01
Date: Tue, 5 Aug 2014 12:48:11 +0800 [thread overview]
Message-ID: <20140805044811.GA17143@kernel> (raw)
In-Reply-To: <1407182196.2571.14.camel@buesod1.americas.hpqcorp.net>
Hi Davidlohr,
On Mon, Aug 04, 2014 at 12:56:36PM -0700, Davidlohr Bueso wrote:
>On Fri, 2014-08-01 at 16:12 +0800, Wanpeng Li wrote:
>> External interrupt will cause L1 vmexit w/ reason external interrupt when L2 is
>> running. Then L1 will pick up the interrupt through vmcs12 if L1 set the ack
>> interrupt bit. Commit 77b0f5d (KVM: nVMX: Ack and write vector info to intr_info
>> if L1 asks us to)
>
>So being that 77b0f5d is in 3.15, we need it for -stable.
>
>> get intr that belongs to L1 before load vmcs01 which is wrong,
>> especially this lead to the obvious L1 ack APICv behavior weired since APICv
>> is for L1 instead of L2. This patch fix it by ack intr after load vmcs01.
>>
>> Signed-off-by: Wanpeng Li <wanpeng.li@linux.intel.com>
>
>It strikes me that this fixes Felipe's issue:
>http://paste.opensuse.org/view/raw/78752586
>
Could you verify if the latest version also fix your issue? Your Tested-by
to the latest version is appreciated.
Regards,
Wanpeng Li
>
>
prev parent reply other threads:[~2014-08-05 4:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 8:12 [PATCH 1/2] KVM: nVMX: Fix nested vmexit ack intr before load vmcs01 Wanpeng Li
2014-08-01 8:12 ` [PATCH 2/2] KVM: nVMX: fix acknowledge interrupt on exit when APICv is in use Wanpeng Li
2014-08-04 2:03 ` Liu, RongrongX
2014-08-04 12:51 ` Paolo Bonzini
2014-08-04 2:01 ` [PATCH 1/2] KVM: nVMX: Fix nested vmexit ack intr before load vmcs01 Liu, RongrongX
2014-08-04 12:51 ` Paolo Bonzini
2014-08-04 19:56 ` Davidlohr Bueso
2014-08-05 4:48 ` Wanpeng Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140805044811.GA17143@kernel \
--to=wanpeng.li@linux.intel.com \
--cc=bsd@redhat.com \
--cc=davidlohr@hp.com \
--cc=freyes@suse.com \
--cc=gleb@kernel.org \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).