From: Sam Ravnborg <sam@ravnborg.org>
To: Nick Krause <xerofoify@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
"Nyman, Mathias" <mathias.nyman@intel.com>,
Alan Stern <stern@rowland.harvard.edu>,
Deepak Saxena <dsaxena@linaro.org>,
"manjunath.goudar" <manjunath.goudar@linaro.org>,
"jg1.han" <jg1.han@samsung.com>, davidm <davidm@egauge.net>,
Ksenia Ragiadakou <burzalodowa@gmail.com>,
hartleys <hartleys@visionengravers.com>,
"gregory.clement" <gregory.clement@free-electrons.com>,
oneukum <oneukum@suse.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
USB list <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] xhci: Merge and Update debugging for patches from 3.6 kernel tree
Date: Tue, 5 Aug 2014 09:05:48 +0200 [thread overview]
Message-ID: <20140805070548.GA27941@ravnborg.org> (raw)
In-Reply-To: <CAPDOMVg_Y7VgdM0ovcS=w7juBZ4n3xnV+kzbtzTxNZjEKzC3sA@mail.gmail.com>
On Tue, Aug 05, 2014 at 01:55:34AM -0400, Nick Krause wrote:
> On Tue, Aug 5, 2014 at 1:45 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Tue, Aug 05, 2014 at 12:56:57AM -0400, Nicholas Krause wrote:
> >> I am adding the fixes to the tree send for adding debugging to the kernel
> >> tree from a patch sent in 2013 on the the 3.6 release. The patch adds
> >> debugging over xhci capable debugging usb ports and needed to be updated
> >> into the latest rc tree. The patch was first sent in this thread,
> >> http://marc.info/?l=linux-usb&m=135948845511047.
> >>
> >> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> >
> You haven't even checked my patch, our you just going to assume it's wrong?
If you spend 20 seconds reding what I quouted above you will find
bugs already.
1) No proper attribution
2) No proper description of the purpose of the patch
And considering the history of your formar patches
3) No documentation on how the patch was verified
There is no need to read the code with so many bugs in the changelog already.
Sam
next prev parent reply other threads:[~2014-08-05 7:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 4:56 [PATCH] xhci: Merge and Update debugging for patches from 3.6 kernel tree Nicholas Krause
2014-08-05 4:59 ` Nick Krause
2014-08-05 5:45 ` Greg KH
2014-08-05 5:55 ` Nick Krause
2014-08-05 7:05 ` Sam Ravnborg [this message]
2014-08-05 7:27 ` Mateusz Guzik
2014-08-05 17:02 ` Nick Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140805070548.GA27941@ravnborg.org \
--to=sam@ravnborg.org \
--cc=burzalodowa@gmail.com \
--cc=davidm@egauge.net \
--cc=dsaxena@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@free-electrons.com \
--cc=hartleys@visionengravers.com \
--cc=jg1.han@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=manjunath.goudar@linaro.org \
--cc=mathias.nyman@intel.com \
--cc=oneukum@suse.de \
--cc=stern@rowland.harvard.edu \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).