From: "Theodore Ts'o" <tytso@mit.edu>
To: Torsten Duwe <duwe@lst.de>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org, Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"H . Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] hwrng: Pass entropy to add_hwgenerator_randomness() in bits, not bytes
Date: Tue, 5 Aug 2014 18:23:03 -0400 [thread overview]
Message-ID: <20140805222303.GB26399@thunk.org> (raw)
In-Reply-To: <20140728094929.GJ972@lst.de>
On Mon, Jul 28, 2014 at 11:49:29AM +0200, Torsten Duwe wrote:
> On Fri, Jul 25, 2014 at 03:19:18PM -0700, Stephen Boyd wrote:
> > rng_get_data() returns the number of bytes read from the hardware.
> > The entropy argument to add_hwgenerator_randomness() is passed
> > directly to credit_entropy_bits() so we should be passing the
> > number of bits, not bytes here.
>
> Absolutely correct.
>
> Acked-by: Torsten Duwe <duwe@suse.de>
Applied, thanks.
- Ted
prev parent reply other threads:[~2014-08-05 22:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 22:19 [PATCH] hwrng: Pass entropy to add_hwgenerator_randomness() in bits, not bytes Stephen Boyd
2014-07-28 9:49 ` Torsten Duwe
2014-08-05 22:23 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140805222303.GB26399@thunk.org \
--to=tytso@mit.edu \
--cc=duwe@lst.de \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox