public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Lan Tianyu <tianyu.lan@intel.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	x86@kernel.org, toshi.kani@hp.com, imammedo@redhat.com,
	jan.kiszka@siemens.com, mingo@kernel.org,
	huawei.libin@huawei.com, prarit@redhat.com,
	linux-kernel@vger.kernel.org, "Brandt,
	Todd E" <todd.e.brandt@intel.com>
Subject: Re: [PATCH] X86/CPU: Avoid 100ms sleep for cpu offline  during S3
Date: Wed, 6 Aug 2014 13:07:48 +0200	[thread overview]
Message-ID: <20140806110748.GC27033@pd.tnic> (raw)
In-Reply-To: <53E0A3EE.50708@intel.com>

On Tue, Aug 05, 2014 at 05:29:18PM +0800, Lan Tianyu wrote:
> I think you can pull Tod's tool from git hub and do test from your
> laptop. I attached a configure file come from ubuntu which is easier
> to produce the issue. You can use it to reproduce the issue.

Right, so I ran it on an old dualcore AMD laptop I have lying around
here and it didn't show any difference with or without your patch.

For all 4 runs I did with the tool running it without any arguments (so
it did the default thing), I got suspend time for CPU1 of 4-6 msec and
resume of ~20msec.

I don't know whether it is the dual core or AMD but your patch doesn't
change anything on that laptop which is ok, I'd guess.

> Ok. BTW, I have tested it on the Ivbridge and Haswell machines.

Yeah, add those numbers to the commit message too.

Thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--

  reply	other threads:[~2014-08-06 11:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-04  8:59 [PATCH] X86/CPU: Avoid 100ms sleep for cpu offline during S3 Lan Tianyu
2014-08-04 10:23 ` Borislav Petkov
     [not found]   ` <53E04457.2060507@intel.com>
2014-08-05  7:54     ` Borislav Petkov
2014-08-05  9:29       ` Lan Tianyu
2014-08-06 11:07         ` Borislav Petkov [this message]
2014-08-06 13:13           ` Lan, Tianyu
2014-08-06 13:57             ` Gene Heskett
2014-08-07  8:47               ` Lan Tianyu
2014-08-07 10:23                 ` Gene Heskett
2014-08-06 16:06             ` Borislav Petkov
2014-08-07  8:56               ` Lan Tianyu
2014-08-05  8:41 ` Borislav Petkov
2014-08-05  9:28   ` Lan Tianyu
2014-08-12  7:31 ` [PATCH V2] " Lan Tianyu
2014-08-12  7:55   ` Borislav Petkov
2014-08-12 11:36   ` Prarit Bhargava

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140806110748.GC27033@pd.tnic \
    --to=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=huawei.libin@huawei.com \
    --cc=imammedo@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=prarit@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tianyu.lan@intel.com \
    --cc=todd.e.brandt@intel.com \
    --cc=toshi.kani@hp.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox