From: Brian Foster <bfoster@redhat.com>
To: Hans Wennborg <hans@hanshq.net>
Cc: david@fromorbit.com, xfs@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/15] xfs: fix decimal printf format specifiers prefixed with 0x
Date: Wed, 6 Aug 2014 08:24:42 -0400 [thread overview]
Message-ID: <20140806122442.GC14820@bfoster.bfoster> (raw)
In-Reply-To: <1407300256-495-1-git-send-email-hans@hanshq.net>
On Tue, Aug 05, 2014 at 09:44:16PM -0700, Hans Wennborg wrote:
> The prefix suggests the number should be printed in hex, so use
> the %x specifier to do that.
>
> Found by using regex suggested by Joe Perches.
>
> Signed-off-by: Hans Wennborg <hans@hanshq.net>
> ---
> fs/xfs/xfs_discard.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_discard.c b/fs/xfs/xfs_discard.c
> index 13d08a1..b4a2415 100644
> --- a/fs/xfs/xfs_discard.c
> +++ b/fs/xfs/xfs_discard.c
> @@ -228,7 +228,7 @@ xfs_discard_extents(
> GFP_NOFS, 0);
> if (error && error != -EOPNOTSUPP) {
> xfs_info(mp,
> - "discard failed for extent [0x%llu,%u], error %d",
> + "discard failed for extent [0x%llx,%u], error %d",
> (unsigned long long)busyp->bno,
> busyp->length,
> error);
It's kind of annoying seeing values of multiple bases being used to
describe a single extent, imo. But using 0x before a decimal value
certainly isn't nice... ;)
Reviewed-by: Brian Foster <bfoster@redhat.com>
> --
> 2.0.0.526.g5318336
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-08-06 12:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 4:44 [PATCH 14/15] xfs: fix decimal printf format specifiers prefixed with 0x Hans Wennborg
2014-08-06 12:24 ` Brian Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140806122442.GC14820@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=hans@hanshq.net \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox