From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753706AbaHFOST (ORCPT ); Wed, 6 Aug 2014 10:18:19 -0400 Received: from mail-we0-f175.google.com ([74.125.82.175]:59951 "EHLO mail-we0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751963AbaHFOSR (ORCPT ); Wed, 6 Aug 2014 10:18:17 -0400 Date: Wed, 6 Aug 2014 15:18:14 +0100 From: Matt Fleming To: Ard Biesheuvel Cc: Leif Lindholm , Dave Young , Catalin Marinas , Will Deacon , Matt Fleming , Mark Salter , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-efi@vger.kernel.org" Subject: Re: [PATCH 1/2] UEFI arm64: add noefi boot param Message-ID: <20140806141814.GD15082@console-pimps.org> References: <20140806083825.GA31711@dhcp-16-198.nay.redhat.com> <20140806130623.GI4179@bivouac.eciton.net> <20140806132021.GB15082@console-pimps.org> <20140806132941.GJ4179@bivouac.eciton.net> <20140806140155.GC15082@console-pimps.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 06 Aug, at 04:10:45PM, Ard Biesheuvel wrote: > > Shouldn't we clear the bit here if we failed to enable runtime > services for some reason? Other code may test the bit assuming that it > signifies that runtime services have been enabled successfully, while > this patch changes it to mean that we /intended/ to enable them, which > is not quite the same thing. Yep, good catch. We need to do something similar for efi_runtime_init() on x86 too. -- Matt Fleming, Intel Open Source Technology Center