public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: "Lan, Tianyu" <tianyu.lan@intel.com>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"toshi.kani@hp.com" <toshi.kani@hp.com>,
	"imammedo@redhat.com" <imammedo@redhat.com>,
	"jan.kiszka@siemens.com" <jan.kiszka@siemens.com>,
	"mingo@kernel.org" <mingo@kernel.org>,
	"huawei.libin@huawei.com" <huawei.libin@huawei.com>,
	"prarit@redhat.com" <prarit@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Brandt, Todd E" <todd.e.brandt@intel.com>
Subject: Re: [PATCH] X86/CPU: Avoid 100ms sleep for cpu offline  during S3
Date: Wed, 6 Aug 2014 18:06:52 +0200	[thread overview]
Message-ID: <20140806160652.GD27033@pd.tnic> (raw)
In-Reply-To: <4CFBC02C07DA244CA19D6815A05BE6EE0119E1CF@SHSMSX103.ccr.corp.intel.com>

Hi,

On Wed, Aug 06, 2014 at 01:13:21PM +0000, Lan, Tianyu wrote:
> Have you tried my attached kernel config file? When someone reported
> the issue to me, I also was very hard to reproduce the issue by my
> own config file. Maybe once 100 tries. But I can reproduced the issue
> every time with the attached configure file on several my machines and
> even on server.

first of all, please do not top-post:

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

Now, it looks like the issue is timing-related, depending on when we're
going to see CPU_DEAD, before or after the msleep. Thus, if some distro
config runs more crap on the suspend path and we don't see the CPU_DEAD
before we sleep for 100ms, then we get to wait at least once and it
shows in the suspend trace.

So, using the completion timeout seems like a net improvement for such
configs and thus for any config.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--

  parent reply	other threads:[~2014-08-06 16:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-04  8:59 [PATCH] X86/CPU: Avoid 100ms sleep for cpu offline during S3 Lan Tianyu
2014-08-04 10:23 ` Borislav Petkov
     [not found]   ` <53E04457.2060507@intel.com>
2014-08-05  7:54     ` Borislav Petkov
2014-08-05  9:29       ` Lan Tianyu
2014-08-06 11:07         ` Borislav Petkov
2014-08-06 13:13           ` Lan, Tianyu
2014-08-06 13:57             ` Gene Heskett
2014-08-07  8:47               ` Lan Tianyu
2014-08-07 10:23                 ` Gene Heskett
2014-08-06 16:06             ` Borislav Petkov [this message]
2014-08-07  8:56               ` Lan Tianyu
2014-08-05  8:41 ` Borislav Petkov
2014-08-05  9:28   ` Lan Tianyu
2014-08-12  7:31 ` [PATCH V2] " Lan Tianyu
2014-08-12  7:55   ` Borislav Petkov
2014-08-12 11:36   ` Prarit Bhargava

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140806160652.GD27033@pd.tnic \
    --to=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=huawei.libin@huawei.com \
    --cc=imammedo@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=prarit@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tianyu.lan@intel.com \
    --cc=todd.e.brandt@intel.com \
    --cc=toshi.kani@hp.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox