From: Guenter Roeck <linux@roeck-us.net>
To: Greg KH <greg@kroah.com>
Cc: Nick Krause <xerofoiffy@gmail.com>,
Richard Weinberger <richard.weinberger@gmail.com>,
Mark Brown <broonie@kernel.org>,
"open list:SPI SUBSYSTEM" <linux-spi@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] spi: Remove unused definitions
Date: Wed, 6 Aug 2014 12:14:30 -0700 [thread overview]
Message-ID: <20140806191430.GA5711@roeck-us.net> (raw)
In-Reply-To: <20140806183319.GA15654@kroah.com>
On Wed, Aug 06, 2014 at 11:33:19AM -0700, Greg KH wrote:
> On Wed, Aug 06, 2014 at 01:53:17PM -0400, Nick Krause wrote:
> > Remove unused definition which cause the following warnings
> >
> > drivers/spi/spi-omap-100k.c:73:0: warning: "WRITE" redefined [enabled by default]
> > include/linux/fs.h:193:0: note: this is the location of the previous definition
> > drivers/spi/spi-omap-100k.c:74:0: warning: "READ" redefined [enabled by default]
> > include/linux/fs.h:192:0: note: this is the location of the previous definition
> >
> > Signed-off-by: Nick Krause <xerofoiffy@gmail.com>
> > ---
> > drivers/spi/spi-omap-100k.c | 4 ----
> > 1 file changed, 4 deletions(-)
>
> Nick, you were warned about this numerous times in the past.
>
> By changing email addresses you have now ensured that we will never
> listen to you, as you obviously are not listening to us.
>
He does manage to get our attention, though. Also, it is not that simple -
for my part I keep looking out for the patches just to make sure that
we don't get any more less than well researched "fixes" into the kernel.
I figure it pays to spend some time now instead of having to clean up
the resulting mess if something slips by.
Guenter
prev parent reply other threads:[~2014-08-06 19:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 17:53 [PATCH 1/1] spi: Remove unused definitions Nick Krause
2014-08-06 18:27 ` Valdis.Kletnieks
2014-08-06 18:35 ` Ilia Mirkin
2014-08-06 18:50 ` Geert Uytterhoeven
2014-08-06 19:34 ` Mark Brown
2014-08-20 20:26 ` Pavel Machek
2014-08-20 21:12 ` Valdis.Kletnieks
2014-08-20 21:56 ` Pavel Machek
2014-08-06 18:33 ` Greg KH
2014-08-06 19:14 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140806191430.GA5711@roeck-us.net \
--to=linux@roeck-us.net \
--cc=broonie@kernel.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=richard.weinberger@gmail.com \
--cc=xerofoiffy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox