From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754681AbaHFTyq (ORCPT ); Wed, 6 Aug 2014 15:54:46 -0400 Received: from mail-we0-f179.google.com ([74.125.82.179]:63174 "EHLO mail-we0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752989AbaHFTyo (ORCPT ); Wed, 6 Aug 2014 15:54:44 -0400 Date: Wed, 6 Aug 2014 21:54:33 +0200 From: Richard Cochran To: Nick Krause Cc: "Koehrer Mathias (ETAS/ESW5)" , Sergei Shtylyov , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH] Fix e1000e with Intel 82572EI that has no hardware timestamp support Message-ID: <20140806195433.GD6611@netboy> References: <20140806191744.GB6611@netboy> <20140806193211.GC6611@netboy> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 06, 2014 at 03:38:18PM -0400, Nick Krause wrote: > I checked them and this patch seems fine to me. No, it isn't fine. It ignores Alexander's comments. Mathias, can you please fix it? Thanks, Richard