public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: A Raghavendra Rao <raghav3276@gmail.com>
Cc: peter.p.waskiewicz.jr@intel.com, c@24.io,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	A Raghavendra Rao <arrao@cdac.in>
Subject: Re: [PATCH] staging: rtl8192u: fix sparse warnings in r8192U_core.c
Date: Wed, 6 Aug 2014 20:08:40 -0700	[thread overview]
Message-ID: <20140807030840.GA2807@kroah.com> (raw)
In-Reply-To: <1407314656-24471-1-git-send-email-arrao@cdac.in>

On Wed, Aug 06, 2014 at 02:14:16PM +0530, A Raghavendra Rao wrote:
> Fix the following sparse warnings:
> drivers/staging/rtl8192u/r8192U_core.c:670:6: warning: symbol 'dump_eprom'
> was not declared. Should it be static?
> drivers/staging/rtl8192u/r8192U_core.c:1556:14: warning: symbol
> 'txqueue2outpipe' was not declared. Should it be static?
> drivers/staging/rtl8192u/r8192U_core.c:4876:5: warning: symbol
> 'GetRxPacketShiftBytes819xUsb' was not declared. Should it be static?
> 
> Signed-off-by: A Raghavendra Rao <arrao@cdac.in>
> ---
>  drivers/staging/rtl8192u/r8192U_core.c |    8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

This patch causes warnings to be added to the build, don't do that :(

  reply	other threads:[~2014-08-07  3:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-06  8:44 [PATCH] staging: rtl8192u: fix sparse warnings in r8192U_core.c A Raghavendra Rao
2014-08-07  3:08 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-08-07  4:40 [PATCH] Staging: " A Raghavendra Rao
2014-08-07  5:35 ` Greg KH
2014-08-07  6:02 ` Antoine Schweitzer-Chaput

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140807030840.GA2807@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arrao@cdac.in \
    --cc=c@24.io \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.p.waskiewicz.jr@intel.com \
    --cc=raghav3276@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox