From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932298AbaHGKKE (ORCPT ); Thu, 7 Aug 2014 06:10:04 -0400 Received: from mail-ie0-f178.google.com ([209.85.223.178]:42642 "EHLO mail-ie0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754650AbaHGKKB (ORCPT ); Thu, 7 Aug 2014 06:10:01 -0400 Date: Thu, 7 Aug 2014 11:09:52 +0100 From: Lee Jones To: Gyungoh Yoo Cc: rdunlap@infradead.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, jg1.han@samsung.com, cooloney@gmail.com, plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, grant.likely@linaro.org, sameo@linux.intel.com, lgirdwood@gmail.com, broonie@kernel.org, jack.yoo@skyworksinc.com, florian.vaussard@epfl.ch, thierry.reding@gmail.com, jason@lakedaemon.net, andrew@lunn.ch, silvio.fricke@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH] Adding a support for Skyworks SKY81452 Message-ID: <20140807100952.GH10136@lee--X1> References: <1407398738-7582-1-git-send-email-jack.yoo@skyworksinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1407398738-7582-1-git-send-email-jack.yoo@skyworksinc.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 07 Aug 2014, Gyungoh Yoo wrote: > Signed-off-by: Gyungoh Yoo > --- > Documentation/backlight/sky81452.txt | 25 ++ > Documentation/devicetree/bindings/mfd/sky81452.txt | 24 ++ > .../bindings/regulator/sky81452-regulator.txt | 16 + > .../devicetree/bindings/vendor-prefixes.txt | 1 + > .../video/backlight/sky81452-backlight.txt | 20 ++ > drivers/mfd/Kconfig | 12 + > drivers/mfd/Makefile | 1 + > drivers/mfd/sky81452.c | 115 +++++++ > drivers/regulator/Kconfig | 11 + > drivers/regulator/Makefile | 1 + > drivers/regulator/sky81452-regulator.c | 127 ++++++++ > drivers/video/backlight/Kconfig | 10 + > drivers/video/backlight/Makefile | 1 + > drivers/video/backlight/sky81452-backlight.c | 333 +++++++++++++++++++++ > include/linux/mfd/sky81452.h | 31 ++ > include/linux/sky81452-backlight.h | 46 +++ > 16 files changed, 774 insertions(+) > create mode 100644 Documentation/backlight/sky81452.txt > create mode 100644 Documentation/devicetree/bindings/mfd/sky81452.txt > create mode 100644 Documentation/devicetree/bindings/regulator/sky81452-regulator.txt > create mode 100644 Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt > create mode 100644 drivers/mfd/sky81452.c > create mode 100644 drivers/regulator/sky81452-regulator.c > create mode 100644 drivers/video/backlight/sky81452-backlight.c > create mode 100644 include/linux/mfd/sky81452.h > create mode 100644 include/linux/sky81452-backlight.h Wow, no way. Please split this up into separate patches. Ideally, at least one per subsystem and separate ones again for the DT bindings. [...] -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog