From: Sam Ravnborg <sam@ravnborg.org>
To: Josh Triplett <josh@joshtriplett.org>
Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org,
David Rientjes <rientjes@google.com>,
"Luis R. Rodriguez" <mcgrof@suse.com>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] x86: Add "make tinyconfig" to configure the tiniest possible kernel
Date: Thu, 7 Aug 2014 21:38:24 +0200 [thread overview]
Message-ID: <20140807193824.GA2351@ravnborg.org> (raw)
In-Reply-To: <20140807190243.GA5580@jtriplet-mobl1>
>
> > > diff --git a/arch/x86/configs/tiny.config b/arch/x86/configs/tiny.config
> > > new file mode 100644
> > > index 0000000..8f0e54c
> > > --- /dev/null
> > > +++ b/arch/x86/configs/tiny.config
> > > @@ -0,0 +1,5 @@
> > > +CONFIG_CC_OPTIMIZE_FOR_SIZE=y
> > > +CONFIG_KERNEL_XZ=y
> > > +CONFIG_NOHIGHMEM=y
> > > +CONFIG_OPTIMIZE_INLINING=y
> > > +CONFIG_SLOB=y
> > All the above are general options that apply equal to arm than to x86.
>
> NOHIGHMEM isn't.
You are right - as it is x86 specific it should had been prefixed
with X86_ to document so.
As the symbol is only relevant for X86 it will not hurt anyone else,
so it is OK to have it.
But it would be nice to document in tiny.config that
this is a X86 specific symbol.
Sam
next prev parent reply other threads:[~2014-08-07 19:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 17:14 [PATCH] x86: Add "make tinyconfig" to configure the tiniest possible kernel Josh Triplett
2014-08-06 22:06 ` David Rientjes
2014-08-06 22:24 ` Josh Triplett
2014-08-06 22:30 ` [PATCH 1/2] x86, platform, kconfig: move kvmconfig functionality to a helper Josh Triplett
2014-08-06 22:33 ` David Rientjes
2014-08-06 22:39 ` Josh Triplett
2014-08-06 22:42 ` David Rientjes
2014-08-06 22:31 ` [PATCH 2/2] x86: Add "make tinyconfig" to configure the tiniest possible kernel Josh Triplett
2014-08-06 22:38 ` David Rientjes
2014-08-06 22:49 ` Josh Triplett
2014-08-06 23:37 ` David Rientjes
2014-08-07 0:04 ` Josh Triplett
2014-08-07 16:03 ` Sam Ravnborg
2014-08-07 19:02 ` Josh Triplett
2014-08-07 19:38 ` Sam Ravnborg [this message]
2014-08-09 0:07 ` [PATCH v3 1/2] x86, platform, kconfig: move kvmconfig functionality to a helper Josh Triplett
2014-08-09 0:10 ` [PATCH v3 2/2] x86: Add "make tinyconfig" to configure the tiniest possible kernel Josh Triplett
2014-08-09 1:22 ` Linus Torvalds
2014-08-11 18:15 ` josh
2014-08-11 19:36 ` Sam Ravnborg
2014-08-15 0:55 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140807193824.GA2351@ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@suse.com \
--cc=mingo@redhat.com \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).