From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756358AbaHHKZm (ORCPT ); Fri, 8 Aug 2014 06:25:42 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:55836 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755883AbaHHKZk (ORCPT ); Fri, 8 Aug 2014 06:25:40 -0400 Date: Fri, 8 Aug 2014 12:25:36 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Julia Lawall Cc: Wolfram Sang , kernel-janitors@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 1/14] i2c: mpc: delete unneeded test before of_node_put Message-ID: <20140808102536.GZ1933@pengutronix.de> References: <1407492475-26283-1-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1407492475-26283-1-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:5054:ff:fec0:8e10 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Fri, Aug 08, 2014 at 12:07:42PM +0200, Julia Lawall wrote: > From: Julia Lawall > > Of_node_put supports NULL as its argument, so the initial test is not > necessary. > > Suggested by Uwe Kleine-König. Thanks for picking up my suggestion. > The semantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > expression e; > @@ > > -if (e) > of_node_put(e); > // > I added devicetree@vger.kernel.org to Cc. Maybe they want to comment the series? If it's acceptable the logical next step is to add the patch to the collection of semantic patches, right? Best regards Uwe > Signed-off-by: Julia Lawall > > --- > drivers/i2c/busses/i2c-mpc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c > index 6a32aa0..0edf630 100644 > --- a/drivers/i2c/busses/i2c-mpc.c > +++ b/drivers/i2c/busses/i2c-mpc.c > @@ -341,8 +341,7 @@ static u32 mpc_i2c_get_sec_cfg_8xxx(void) > iounmap(reg); > } > } > - if (node) > - of_node_put(node); > + of_node_put(node); > > return val; > } > > -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |