* [PATCH] rtsx_usb: export device table
@ 2014-08-08 21:31 Jeff Mahoney
2014-08-08 22:20 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Mahoney @ 2014-08-08 21:31 UTC (permalink / raw)
To: Roger Tseng, akpm, Linux Kernel Maling List
The rtsx_usb driver contains the table for the devices it supports but
doesn't export it. As a result, no alias is generated and it doesn't
get loaded automatically.
Via https://bugzilla.novell.com/show_bug.cgi?id=890096
Reported-by: Marcel Witte <wittemar@googlemail.com>
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
---
drivers/mfd/rtsx_usb.c | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/mfd/rtsx_usb.c
+++ b/drivers/mfd/rtsx_usb.c
@@ -744,6 +744,7 @@ static struct usb_device_id rtsx_usb_usb
{ USB_DEVICE(0x0BDA, 0x0140) },
{ }
};
+MODULE_DEVICE_TABLE(usb, rtsx_usb_usb_ids);
static struct usb_driver rtsx_usb_driver = {
.name = "rtsx_usb",
--
Jeff Mahoney
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] rtsx_usb: export device table
2014-08-08 21:31 [PATCH] rtsx_usb: export device table Jeff Mahoney
@ 2014-08-08 22:20 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2014-08-08 22:20 UTC (permalink / raw)
To: Jeff Mahoney; +Cc: Roger Tseng, Linux Kernel Maling List
On Fri, 08 Aug 2014 17:31:51 -0400 Jeff Mahoney <jeffm@suse.com> wrote:
> The rtsx_usb driver contains the table for the devices it supports but
> doesn't export it. As a result, no alias is generated and it doesn't
> get loaded automatically.
>
> Via https://bugzilla.novell.com/show_bug.cgi?id=890096
>
> ...
>
> --- a/drivers/mfd/rtsx_usb.c
> +++ b/drivers/mfd/rtsx_usb.c
> @@ -744,6 +744,7 @@ static struct usb_device_id rtsx_usb_usb
> { USB_DEVICE(0x0BDA, 0x0140) },
> { }
> };
> +MODULE_DEVICE_TABLE(usb, rtsx_usb_usb_ids);
>
> static struct usb_driver rtsx_usb_driver = {
> .name = "rtsx_usb",
>
I'd normally duck a patch like this because I don't do MFD.
But you omitted the Cc:stable tag, so I grabbed the patch to ensure
that this tag is included.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-08 22:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-08 21:31 [PATCH] rtsx_usb: export device table Jeff Mahoney
2014-08-08 22:20 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).