Re: [PATCH v3 tip/core/rcu 3/9] rcu: Add synchronous grace-period waiting for RCU-tasks

Steven Rostedt
2014-08-08T16:40:23Z

On Fri, 8 Aug 2014 18:17:09 +0200
Peter Zijlstra <peterz@infradead.org> wrote:

> On Fri, Aug 08, 2014 at 11:39:49AM -0400, Steven Rostedt wrote:
> > Also, anyone can register a function handler (perf, systemtap, and even
> > LTTng can).
>
> So how common is it to have more than 1 function event handler, and how
> many of those cases is there significant difference in the actual
> functions?

For me, it's quite common. Of course, I tend to poweruse function
tracing :-). I do make instances and trace a few functions here and
there, while tracing all functions.

Note, if you are tracing all functions, all it takes is just adding one
other ops callback to a single function. That is, if you are tracing
all functions, and add another ops, it will make all users use the list
function. That is. Even though only one function has two callbacks
attached to it, all functions will call the list function, which does
make a noticeable difference. I measured it once before, I'll have to
do it again.

Tracing all functions is extremely invasive, and any increase in the
time of the function callback handlers will have a dramatic hit on
performance.

An mcount nop, causes 13% slowdown. Imagine what adding a loop does.

>
> Because that's the case you're optimizing for. Why is that an important
> enough case.
>
> I'm thinking I'll never trigger that, I only ever have the one normal
> ftrace handler. So no trampolines for me, the code you have now works
> just fine.
>

And it will work just fine afterward :-)

I will treat any regressions as a significant (high priority) bug.

-- Steve