Re: [PATCH v3 tip/core/rcu 1/9] rcu: Add call_rcu_tasks()

Oleg Nesterov
2014-08-02T14:58:58Z

On 07/31, Paul E. McKenney wrote:
>
> + rcu_read_lock();
> + for_each_process_thread(g, t) {
> + if (t != current && ACCESS_ONCE(t->on_rq) &&
> + !is_idle_task(t)) {

I didn't notice this check before, but it is not needed. for_each_process()
can see the idle threads, there are not on process/thread lists.

But this doesn't really matter, the main problem is that I still think that
for_each_process_thread() can't really work anyway.

Oleg.