Re: [PATCH v3 tip/core/rcu 3/9] rcu: Add synchronous grace-period waiting for RCU-tasks

Peter Zijlstra
2014-08-07T08:46:04Z

[-- Attachment #1: Type: text/plain, Size: 931 bytes --]

On Wed, Aug 06, 2014 at 03:45:18PM -0700, Paul E. McKenney wrote:
> > > > But I still very much hate the polling stuff...
>
> The nice thing about the polling approach is minimal overhead in the
> common case where RCU-tasks is not in use.

No, quite the reverse, there is overhead when its not in use, as opposed
to no overhead at all.

I'm still not convinced we need this 'generic' rcu-task stuff and create
yet another kthread with polling semantics, we want to let the system
idle out when there's nothing to do, not keep waking it up.

So do we really need the call_rcu_task() thing and why isn't something
like synchronize_tasks() good enough?

So the thing is, the one proposed user is very rare (*) and for that
you're adding overhead outside of that user (a separate kthread) and
your adding overhead when its not used.

* I'm assuming that, since tracing is 'rare' and this is some tracing
thing.

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]