Re: [PATCH v3 tip/core/rcu 1/9] rcu: Add call_rcu_tasks()

Peter Zijlstra
2014-08-04T07:46:35Z

[-- Attachment #1: Type: text/plain, Size: 772 bytes --]

On Mon, Aug 04, 2014 at 09:28:45AM +0800, Lai Jiangshan wrote:
> On 08/01/2014 05:55 AM, Paul E. McKenney wrote:
> > + rcu_read_lock();
> > + for_each_process_thread(g, t) {
> > + if (t != current && ACCESS_ONCE(t->on_rq) &&
> > + !is_idle_task(t)) {
> > + get_task_struct(t);
> > + t->rcu_tasks_nvcsw = ACCESS_ONCE(t->nvcsw);
> > + ACCESS_ONCE(t->rcu_tasks_holdout) = 1;
> > + list_add(&t->rcu_tasks_holdout_list,
> > + &rcu_tasks_holdouts);
>
> This loop will collect all the runnable tasks. It is too much tasks.
> Is it possible to collect only on_cpu tasks or PREEMPT_ACTIVE tasks?
> It seems hard to achieve it.

Without taking the rq->lock you cannot do that race-free. And we're not
going to be taking rq->lock here.

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]