linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: John Stultz <john.stultz@linaro.org>
Cc: Kees Cook <keescook@chromium.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Chris Ball <chris@printf.net>,
	Peter Maydell <peter.maydell@linaro.org>,
	Johan Rudholm <jrudholm@gmail.com>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [Regression] 3.15 mmc related ext4 corruption with qemu-system-arm
Date: Fri, 8 Aug 2014 20:32:17 -0400	[thread overview]
Message-ID: <20140809003217.GS25145@thunk.org> (raw)
In-Reply-To: <53E568B2.40206@linaro.org>

On Fri, Aug 08, 2014 at 05:17:54PM -0700, John Stultz wrote:
> On 08/08/2014 05:15 PM, Kees Cook wrote:
> > On Fri, Aug 8, 2014 at 2:14 PM, John Stultz <john.stultz@linaro.org> wrote:
> >> I sunk a couple of weeks bisecting to try to narrow down the more
> >> sporadic issue, but was unsuccessful past the initial commit above.
> >> Since then I've been far too swamped to spend any more time on it. Even
> >> so, its a *major* pain for testing but it seems like no one else really
> >> cares?
> > I'm in the same boat as far as poor bisection results. :(
> >
> > However, I keep using the 3-patch mmci fix series from Ulf, and
> > haven't hit any trouble with them. Though perhaps I'm just getting
> > lucky?
> >
> > http://git.kernel.org/cgit/linux/kernel/git/kees/linux.git/log/?h=arm/fix-mmci
> 
> I guess I'll give that another shot 

There was an ext4 bug that might have caused this problem.  It was
fixed in v3.15.6 and v3.16-rc5.

commit f9ae9cf5d72b3926ca48ea60e15bdbb840f42372
Author: Theodore Ts'o <tytso@mit.edu>
Date:   Fri Jul 11 13:55:40 2014 -0400

    ext4: revert commit which was causing fs corruption after journal replays
    
    Commit 007649375f6af2 ("ext4: initialize multi-block allocator before
    checking block descriptors") causes the block group descriptor's count
    of the number of free blocks to become inconsistent with the number of
    free blocks in the allocation bitmap.  This is a harmless form of fs
    corruption, but it causes the kernel to potentially remount the file
    system read-only, or to panic, depending on the file systems's error
    behavior.
    
    Thanks to Eric Whitney for his tireless work to reproduce and to find
    the guilty commit.
    
    Fixes: 007649375f6af2 ("ext4: initialize multi-block allocator before checki
    
    Cc: stable@vger.kernel.org  # 3.15
    Reported-by: David Jander <david@protonic.nl>
    Reported-by: Matteo Croce <technoboy85@gmail.com>
    Tested-by: Eric Whitney <enwlinux@gmail.com>
    Suggested-by: Eric Whitney <enwlinux@gmail.com>
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>

The bug wouldn't always trigger, which is probably why it gave you so
much trouble trying to do the bisect.

Cheers,

					- Ted

  reply	other threads:[~2014-08-09  0:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-12  5:35 [Regression] 3.15 mmc related ext4 corruption with qemu-system-arm John Stultz
2014-06-12 12:09 ` Ulf Hansson
2014-06-12 12:15   ` Peter Maydell
2014-06-13 11:35     ` Ulf Hansson
2014-06-12 23:51 ` John Stultz
2014-06-13 12:28   ` Ulf Hansson
2014-06-16  7:22     ` Jeff Chua
2014-06-16 13:02       ` Ulf Hansson
2014-08-08 21:14 ` John Stultz
2014-08-09  0:15   ` Kees Cook
2014-08-09  0:17     ` John Stultz
2014-08-09  0:32       ` Theodore Ts'o [this message]
2014-08-09  4:03         ` John Stultz
2014-08-11  8:04           ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140809003217.GS25145@thunk.org \
    --to=tytso@mit.edu \
    --cc=chris@printf.net \
    --cc=john.stultz@linaro.org \
    --cc=jrudholm@gmail.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=peter.maydell@linaro.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).