public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Vincent Bernat <vincent@bernat.im>
Cc: Eli Billauer <eli.billauer@gmail.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: xillybus: fix some coding style errors
Date: Sat, 9 Aug 2014 20:34:13 -0700	[thread overview]
Message-ID: <20140810033413.GA20872@kroah.com> (raw)
In-Reply-To: <1405516782-11434-1-git-send-email-vincent@bernat.im>

On Wed, Jul 16, 2014 at 03:19:42PM +0200, Vincent Bernat wrote:
> This includes:
>  - keep "else" on the same line as the closing brace
>  - don't use "else" after "return"
>  - don't issue a message for an out-of-memory error
>  - blank line after a declaration
> 
> Signed-off-by: Vincent Bernat <vincent@bernat.im>
> ---
>  drivers/staging/xillybus/xillybus_core.c | 13 +++++--------
>  1 file changed, 5 insertions(+), 8 deletions(-)

This patch doesn't apply at all, as I think you made it against an old
kernel tree :(

  reply	other threads:[~2014-08-10 12:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-16 13:19 [PATCH] staging: xillybus: fix some coding style errors Vincent Bernat
2014-08-10  3:34 ` Greg Kroah-Hartman [this message]
2014-08-10 12:16   ` Vincent Bernat
2014-08-10 12:25     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140810033413.GA20872@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=eli.billauer@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vincent@bernat.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox