From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751481AbaHJMLB (ORCPT ); Sun, 10 Aug 2014 08:11:01 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:42739 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751387AbaHJMLA (ORCPT ); Sun, 10 Aug 2014 08:11:00 -0400 Date: Sat, 9 Aug 2014 20:34:13 -0700 From: Greg Kroah-Hartman To: Vincent Bernat Cc: Eli Billauer , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: xillybus: fix some coding style errors Message-ID: <20140810033413.GA20872@kroah.com> References: <1405516782-11434-1-git-send-email-vincent@bernat.im> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1405516782-11434-1-git-send-email-vincent@bernat.im> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 16, 2014 at 03:19:42PM +0200, Vincent Bernat wrote: > This includes: > - keep "else" on the same line as the closing brace > - don't use "else" after "return" > - don't issue a message for an out-of-memory error > - blank line after a declaration > > Signed-off-by: Vincent Bernat > --- > drivers/staging/xillybus/xillybus_core.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) This patch doesn't apply at all, as I think you made it against an old kernel tree :(