* [PATCH] staging: rtl8188eu: HalPhyRf_8188e: Fix static symbol sparse warning
@ 2014-08-05 20:03 Miguel Oliveira
2014-08-10 4:25 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Miguel Oliveira @ 2014-08-05 20:03 UTC (permalink / raw)
To: gregkh; +Cc: navin.patidar, Larry.Finger, devel, linux-kernel, cmroliv
Fix sparse warning:
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c:25:4: warning: symbol 'ODM_GetRightChnlPlaceforIQK' was not declared. Should it be static?
by making it static since it's only used once.
Signed-off-by: Miguel Oliveira <cmroliv@gmail.com>
---
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c b/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c
index 7fa744b..d2bcc16 100644
--- a/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c
+++ b/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c
@@ -22,7 +22,7 @@
#define ODM_TXPWRTRACK_MAX_IDX_88E 6
-u8 ODM_GetRightChnlPlaceforIQK(u8 chnl)
+static u8 ODM_GetRightChnlPlaceforIQK(u8 chnl)
{
u8 channel_all[ODM_TARGET_CHNL_NUM_2G_5G] = {
1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: rtl8188eu: HalPhyRf_8188e: Fix static symbol sparse warning
2014-08-05 20:03 [PATCH] staging: rtl8188eu: HalPhyRf_8188e: Fix static symbol sparse warning Miguel Oliveira
@ 2014-08-10 4:25 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2014-08-10 4:25 UTC (permalink / raw)
To: Miguel Oliveira; +Cc: devel, linux-kernel, Larry.Finger
On Tue, Aug 05, 2014 at 09:03:48PM +0100, Miguel Oliveira wrote:
> Fix sparse warning:
> drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c:25:4: warning: symbol 'ODM_GetRightChnlPlaceforIQK' was not declared. Should it be static?
> by making it static since it's only used once.
>
> Signed-off-by: Miguel Oliveira <cmroliv@gmail.com>
> ---
> drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c b/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c
> index 7fa744b..d2bcc16 100644
> --- a/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c
> +++ b/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c
> @@ -22,7 +22,7 @@
> #define ODM_TXPWRTRACK_MAX_IDX_88E 6
>
>
> -u8 ODM_GetRightChnlPlaceforIQK(u8 chnl)
> +static u8 ODM_GetRightChnlPlaceforIQK(u8 chnl)
> {
> u8 channel_all[ODM_TARGET_CHNL_NUM_2G_5G] = {
> 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14,
Someone else made this change already, always work against the
linux-next tree :(
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-10 12:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-05 20:03 [PATCH] staging: rtl8188eu: HalPhyRf_8188e: Fix static symbol sparse warning Miguel Oliveira
2014-08-10 4:25 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox