Re: [PATCH] net: ugg_geth: Fix build error in -next

Uwe Kleine-König
2014-08-10T18:36:29Z

Hello Guenter,

On Sun, Aug 10, 2014 at 09:19:14AM -0700, Guenter Roeck wrote:
> powerpc:mpc83xx_defconfig and other builds fail with
>
> drivers/net/ethernet/freescale/ucc_geth.c: In function 'ucc_geth_remove':
> drivers/net/ethernet/freescale/ucc_geth.c:3927:19: error:
> 'struct ucc_geth_private' has no member named 'info'
> of_node_put(ugeth->info->tbi_node);
> ^
> drivers/net/ethernet/freescale/ucc_geth.c:3928:19: error:
> 'struct ucc_geth_private' has no member named 'info'
> of_node_put(ugeth->info->phy_node);
> ^
>
> Introduced by commit "net: ucc_geth: drop acquired references in probe error
> path and remove".
>
> From the context, it appears that the variable is named ug_info.
>
> Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> Only seen in -next.
My patch was only sent just now, but it has the subject right:

http://mid.gmane.org/1407695525-32227-1-git-send-email-u.kleine-koenig@pengutronix.de

Another upside is that it contains a Fixes: header.

Other than that my patch is the same. In case davem picks up yours:

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Best regards and thanks
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |