public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Kees Cook <keescook@chromium.org>
Cc: Guenter Roeck <private@roeck-us.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andy Lutomirski <luto@amacapital.net>
Subject: Re: Runtime trouble with commit dbd952127d (seccomp: introduce writer locking)
Date: Sun, 10 Aug 2014 21:33:08 +0200	[thread overview]
Message-ID: <20140810193308.GA31867@redhat.com> (raw)
In-Reply-To: <CAGXu5jLsbCpqG2cAxZWG+ZC=wdvhQ_9GPqXUb6p9pSvsqrXpOA@mail.gmail.com>

On 08/09, Kees Cook wrote:
>
> On Sat, Aug 9, 2014 at 6:47 PM, Guenter Roeck <private@roeck-us.net> wrote:
> > Hi folks,
> >
> > I am having some trouble with commit dbd952127d (seccomp: introduce
> > writer locking) when running my qemu tests on the upstream kernel.
>
> Eek, sorry this is causing you trouble!
>
> > With powerpc, I get the following crash.
> >
> > ftrace: allocating 20093 entries in 59 pages
> > ------------[ cut here ]------------
> > kernel BUG at kernel/fork.c:1108!
>
> For your tree, does this resolve to copy_seccomp()'s
>
>         BUG_ON(!spin_is_locked(&current->sighand->siglock));
>
> line?

This is almost off-topic, and I too do not understand whats going on...

But I'd suggest to change this check to use  lockdep_is_held() in any
case.

Oleg.


  parent reply	other threads:[~2014-08-10 19:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-10  1:47 Runtime trouble with commit dbd952127d (seccomp: introduce writer locking) Guenter Roeck
2014-08-10  3:18 ` Kees Cook
2014-08-10  5:37   ` Guenter Roeck
2014-08-10 18:35   ` Guenter Roeck
2014-08-10 19:33   ` Oleg Nesterov [this message]
2014-08-10 20:51     ` Guenter Roeck
2014-08-10 21:10       ` Linus Torvalds
2014-08-10 23:18         ` Guenter Roeck
2014-08-11  0:05           ` Linus Torvalds
2014-08-11 11:48             ` Oleg Nesterov
2014-08-11 14:11               ` Guenter Roeck
2014-08-11 19:51                 ` Kees Cook
2014-08-11 20:26                   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140810193308.GA31867@redhat.com \
    --to=oleg@redhat.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=private@roeck-us.net \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox