From: Wolfram Sang <wsa@the-dreams.de>
To: Mark D Rustad <mrustad@gmail.com>
Cc: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Peter Hurley <peter@hurleysoftware.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc: ti-st: st_kim.c: Cleaning up missing null-terminate after strncpy call
Date: Mon, 11 Aug 2014 11:14:37 +0200 [thread overview]
Message-ID: <20140811091437.GA2730@katana> (raw)
In-Reply-To: <6ACE8FE9-A4AD-4A7A-890F-49F42B81C0A4@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 206 bytes --]
> > strncpy(kim_data->dev_name, buf, count);
> > + kim_data->dev_name[count - 1] = '\n';
>
> Of course this does not add termination, but adds a newline at the end of the buffer? Huh?
strlcpy?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-08-11 9:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-09 23:45 [PATCH] misc: ti-st: st_kim.c: Cleaning up missing null-terminate after strncpy call Rickard Strandqvist
2014-08-11 1:01 ` Mark D Rustad
2014-08-11 9:14 ` Wolfram Sang [this message]
2014-08-11 19:45 ` Rickard Strandqvist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140811091437.GA2730@katana \
--to=wsa@the-dreams.de \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mrustad@gmail.com \
--cc=peter@hurleysoftware.com \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox