From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Oleg Drokin <oleg.drokin@intel.com>,
devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>,
Hongchao Zhang <hongchao.zhang@intel.com>,
Peng Tao <bergwolf@gmail.com>,
Alex Zhuravlev <alexey.zhuravlev@intel.com>,
linux-kernel@vger.kernel.org, Ann Koehler <amk@cray.com>,
Christoph Jaeger <email@christophjaeger.info>,
Lisa Nguyen <lisa@xenapiadmin.com>
Subject: Re: [PATCH] staging: lustre: lustre: obdclass: genops.c: Cleaning up missing null-terminate after strncpy call
Date: Mon, 11 Aug 2014 13:55:51 +0300 [thread overview]
Message-ID: <20140811105550.GM4856@mwanda> (raw)
In-Reply-To: <1407628080-24789-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On Sun, Aug 10, 2014 at 01:48:00AM +0200, Rickard Strandqvist wrote:
> Added a guaranteed null-terminate after call to strncpy.
>
No. This one isn't needed. The static checker *should* know this so it
is a problem with the static checker and not with the code.
Don't change code, just because the static checker has problems.
regards,
dan carpenter
prev parent reply other threads:[~2014-08-11 10:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-09 23:48 [PATCH] staging: lustre: lustre: obdclass: genops.c: Cleaning up missing null-terminate after strncpy call Rickard Strandqvist
2014-08-11 10:55 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140811105550.GM4856@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alexey.zhuravlev@intel.com \
--cc=amk@cray.com \
--cc=andreas.dilger@intel.com \
--cc=bergwolf@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=email@christophjaeger.info \
--cc=gregkh@linuxfoundation.org \
--cc=hongchao.zhang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lisa@xenapiadmin.com \
--cc=oleg.drokin@intel.com \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox