From: Dan Carpenter <dan.carpenter@oracle.com>
To: Srikrishan Malik <srikrishanmalik@gmail.com>,
Joe Perches <joe@perches.com>,
greg@kroah.com, andreas.dilger@intel.com, oleg.drokin@intel.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/12] staging: lustre: Fix misplaced opening brace warnings
Date: Mon, 11 Aug 2014 15:54:22 +0300 [thread overview]
Message-ID: <20140811110745.GJ11899@mwanda> (raw)
In-Reply-To: <20140811105706.GA17691@mordor.in.ibm.com>
On Mon, Aug 11, 2014 at 04:27:06PM +0530, Srikrishan Malik wrote:
> This patch set is aimed at removing checkpatch issues from files in
> lustre/lustre/mdc.
>
> Is it ok if I just fix those in this set and post another patch set
> to take care of other issues identified in review?
checkpatch fixes are worthless if they don't make the code better for
human readers.
>
> - removing typedef for ldlm_policy_data_t will touch many other
> files/dirs which were not initially targeted for this patch set.
Yeah. You're right. This should be done in a separate patch because
it doesn't completely fall under the "cleanup variable declarations in
mdc_enqueue()" header.
> - There can be a separate patch to remove __u64.
It's all part of the same thing "variable declarations in that
function."
regards,
dan carpenter
next prev parent reply other threads:[~2014-08-11 13:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 17:12 [PATCH 01/12] staging: lustre: remove space between function name and and open parenthesis Srikrishan Malik
2014-08-06 17:12 ` [PATCH 02/12] staging: lustre: remove spaces from start of line Srikrishan Malik
2014-08-06 17:12 ` [PATCH 03/12] staging: lustre: move open brace to next line after functions Srikrishan Malik
2014-08-06 17:12 ` [PATCH 04/12] staging: lustre: fix lines over 80 chars Srikrishan Malik
2014-08-06 17:12 ` [PATCH 05/12] staging: lustre: Add missing spaces around operators and braces Srikrishan Malik
2014-08-06 20:13 ` Dan Carpenter
2014-08-06 20:31 ` Joe Perches
2014-08-06 20:45 ` Dan Carpenter
2014-08-06 21:26 ` Joe Perches
2014-08-06 17:12 ` [PATCH 06/12] staging: lustre: replace c99 style comments with C89 Srikrishan Malik
2014-08-06 20:15 ` Dan Carpenter
2014-08-06 17:12 ` [PATCH 07/12] staging: lustre: add blank lines after declarations Srikrishan Malik
2014-08-06 17:12 ` [PATCH 08/12] staging: lustre: fix multi line strings Srikrishan Malik
2014-08-06 17:12 ` [PATCH 09/12] staging: lustre: Added space between type name and * Srikrishan Malik
2014-08-06 17:13 ` [PATCH 10/12] staging: lustre: Fix misplaced opening brace warnings Srikrishan Malik
2014-08-06 20:18 ` Dan Carpenter
2014-08-07 15:31 ` Srikrishan Malik
2014-08-07 16:01 ` Dan Carpenter
2014-08-07 16:35 ` Joe Perches
2014-08-11 10:57 ` Srikrishan Malik
2014-08-11 11:36 ` Joe Perches
2014-08-11 14:21 ` Julia Lawall
2014-08-11 12:54 ` Dan Carpenter [this message]
2014-08-06 17:13 ` [PATCH 11/12] staging: lustre: move else on the same line as closing brace Srikrishan Malik
2014-08-06 17:13 ` [PATCH 12/12] staging: lustre: remove parentheses usage with return Srikrishan Malik
2014-08-10 4:32 ` [PATCH 01/12] staging: lustre: remove space between function name and and open parenthesis Greg KH
2014-08-10 14:43 ` Srikrishan Malik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140811110745.GJ11899@mwanda \
--to=dan.carpenter@oracle.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
--cc=srikrishanmalik@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox