From: Oleg Nesterov <oleg@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
Kees Cook <keescook@chromium.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andy Lutomirski <luto@amacapital.net>
Subject: Re: Runtime trouble with commit dbd952127d (seccomp: introduce writer locking)
Date: Mon, 11 Aug 2014 13:48:23 +0200 [thread overview]
Message-ID: <20140811114822.GA2122@redhat.com> (raw)
In-Reply-To: <CA+55aFyus4Le7EeCEaJpcVVshtwK93Et1C0AkPaC=5QnXJYjGw@mail.gmail.com>
On 08/10, Linus Torvalds wrote:
>
> So that should just be converted to assert_spin_is_locked().
I still think that lockdep_assert_held() is better. Unlike
assert_spin_locked() it checks that this lock is held by us, and this
is what we want in this case.
Plus it depends on CONFIG_LOCKDEP, this is probably good too.
Oleg.
next prev parent reply other threads:[~2014-08-11 11:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-10 1:47 Runtime trouble with commit dbd952127d (seccomp: introduce writer locking) Guenter Roeck
2014-08-10 3:18 ` Kees Cook
2014-08-10 5:37 ` Guenter Roeck
2014-08-10 18:35 ` Guenter Roeck
2014-08-10 19:33 ` Oleg Nesterov
2014-08-10 20:51 ` Guenter Roeck
2014-08-10 21:10 ` Linus Torvalds
2014-08-10 23:18 ` Guenter Roeck
2014-08-11 0:05 ` Linus Torvalds
2014-08-11 11:48 ` Oleg Nesterov [this message]
2014-08-11 14:11 ` Guenter Roeck
2014-08-11 19:51 ` Kees Cook
2014-08-11 20:26 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140811114822.GA2122@redhat.com \
--to=oleg@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=luto@amacapital.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox