From: Thierry Reding <thierry.reding@gmail.com>
To: Mikko Perttunen <mperttunen@nvidia.com>
Cc: tj@kernel.org, swarren@wwwdotorg.org, linux-ide@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: ahci_tegra: Read calibration fuse
Date: Mon, 11 Aug 2014 15:42:29 +0200 [thread overview]
Message-ID: <20140811134227.GB26128@ulmo.nvidia.com> (raw)
In-Reply-To: <1407755953-11785-1-git-send-email-mperttunen@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1058 bytes --]
On Mon, Aug 11, 2014 at 02:19:13PM +0300, Mikko Perttunen wrote:
> The original version of the driver did not read the SATA calibration
> fuse to remove the dependency to the fuse driver. The fuse driver
> is now merged, so add this functionality.
>
> The calibration fuse contains a 2-bit value used to pick a set
> of calibration values for the SATA pad.
>
> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
> ---
> drivers/ata/ahci_tegra.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c
> index f1fef74..ad99e0f5 100644
> --- a/drivers/ata/ahci_tegra.c
> +++ b/drivers/ata/ahci_tegra.c
> @@ -26,6 +26,7 @@
> #include <linux/platform_device.h>
> #include <linux/regulator/consumer.h>
> #include <soc/tegra/pmc.h>
> +#include <soc/tegra/fuse.h>
The above should be sorted alphabetically. Also I personally prefer to
visually separate linux/ and soc/ (just like asm/) headers by separating
the lists with empty lines.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-08-11 13:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-11 11:19 [PATCH] ata: ahci_tegra: Read calibration fuse Mikko Perttunen
2014-08-11 13:42 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140811134227.GB26128@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox