From: Greg KH <gregkh@linuxfoundation.org>
To: Avinash kumar <avi.kp.137@gmail.com>
Cc: forest@alittletooquiet.net, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: staging: vt6655: wpactl.h: corrected comment format
Date: Tue, 12 Aug 2014 02:48:22 +0800 [thread overview]
Message-ID: <20140811184822.GA947@kroah.com> (raw)
In-Reply-To: <1407779792-7926-1-git-send-email-avi.kp.137@gmail.com>
On Mon, Aug 11, 2014 at 11:26:32PM +0530, Avinash kumar wrote:
> corrected C99 style comment format related error
>
> Signed-off-by: Avinash Kumar <avi.kp.137@gmail.com>
> ---
> drivers/staging/vt6655/wpactl.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vt6655/wpactl.h b/drivers/staging/vt6655/wpactl.h
> index f7638ba..2ff42c5 100644
> --- a/drivers/staging/vt6655/wpactl.h
> +++ b/drivers/staging/vt6655/wpactl.h
> @@ -36,7 +36,7 @@
>
> /*--------------------- Export Definitions -------------------------*/
>
> -//WPA related
> +/*WPA related*/
Shouldn't you use 2 extra ' ' characters here?
> enum wpa_alg { WPA_ALG_NONE, WPA_ALG_WEP, WPA_ALG_TKIP, WPA_ALG_CCMP };
> enum wpa_cipher { CIPHER_NONE, CIPHER_WEP40, CIPHER_TKIP, CIPHER_CCMP,
> @@ -61,4 +61,4 @@ int wpa_set_wpadev(PSDevice pDevice, int val);
> int wpa_ioctl(PSDevice pDevice, struct iw_point *p);
> int wpa_set_keys(PSDevice pDevice, void *ctx, bool fcpfkernel);
>
> -#endif // __WPACL_H__
> +#endif /* __WPACL_H__*/
And one extra ' ' here, right before the '*/' please.
thanks,
greg k-h
prev parent reply other threads:[~2014-08-11 18:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-11 17:56 [PATCH] drivers: staging: vt6655: wpactl.h: corrected comment format Avinash kumar
2014-08-11 18:48 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140811184822.GA947@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=avi.kp.137@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox